From: Leo Butler <Leo.Butler@umanitoba.ca>
To: Max Nikulin <email@example.com>
Cc: Org Mode Mailing List <firstname.lastname@example.org>
Subject: Re: [PATCH] remove unused code in ob-octave.el
Date: Tue, 14 Feb 2023 17:50:24 +0000 [thread overview]
Message-ID: <email@example.com> (raw)
In-Reply-To: <firstname.lastname@example.org> (Max Nikulin's message of "Fri, 10 Feb 2023 09:32:05 +0700")
On Fri, Feb 10 2023, Max Nikulin <email@example.com> wrote:
> On 10/02/2023 04:21, Leo Butler wrote:
>> In lisp/ob-octave.el:
>> What is the point of ob-octave-prep-session:octave or its brother,
>> These two functions are unused in the existing code.
> Have you checked the following? I am not familiar with org-babel code.
> grep -nH org-babel-prep-session lisp/ob-core.el
> lisp/ob-core.el:1041: (prep-cmd (intern (concat
> "org-babel-prep-session:" lang))))
> lisp/ob-core.el:1050: (error "No org-babel-prep-session function for
> %s!" lang))
> Do test passes when you patch is applied? It might mean that test
> coverage is not perfect.
Yes, the tests pass after removing the code.
I can see from your and Ihor's response that my suggestion is
After looking more carefully at ob-core, I am not sure how I could write
a test for the prep-session code, though. The comment and docstring in
ob-template.el does not help me, I am afraid. And the existing
session-related tests do not touch the prep-session code.
I'll poke around in other ob-*.el code and see if I can figure it out.
next prev parent reply other threads:[~2023-02-14 17:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 21:21 [PATCH] remove unused code in ob-octave.el Leo Butler
2023-02-10 2:32 ` Max Nikulin
2023-02-14 17:50 ` Leo Butler [this message]
2023-02-10 12:02 ` Ihor Radchenko
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).