From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 4KS2D6pCz2QtGQAASxT56A (envelope-from ) for ; Sun, 06 Aug 2023 08:50:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id GNMUD6pCz2RwZgAAauVa8A (envelope-from ) for ; Sun, 06 Aug 2023 08:50:18 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E2EAD4A9E6 for ; Sun, 6 Aug 2023 08:50:17 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=puN48DGQ; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1691304618; a=rsa-sha256; cv=none; b=BknZDGkxwXsQazHAY+A+kaim7AjqQhMnZ5MaNQAYkshJrwltr4rZZS6HumQzb2EaOejSup Jd0Ve9nSc0V7wsKdDLlB0qo9RhKa4V0bWaRBqHhMUFFj2JEIMOSURaNc9nA4d+Hlw1aSdF MJoCQddgJilue2lnpCVHVPmUjUajdFYOIFwlDAbwHk8jz9kMFmvjOYXnuGe5FJ/6f6I0cx vW5PLANqCxITzZE+w6J2BxVaWGzMpsMIAdXEMZQcXIO3sm9mcFGqBux3kFQ2IbztBEVu5J LH1aFviydyn/YG3ussyM3O1aSG1UIIJ7JjWxmnH7e2wMLqYNnh4pYrpqiuUgWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1691304618; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=NnDX3nEV9mqtZpBdWeWCf7FfVN5eA3Zt9W/P1NI4pgU=; b=HHybkVATGJRCKUj+fKh9ot9SNDkJ+GCtse32/PgaTAxl2sHmdFbG81rUQTTD6zRCW4/FWt FIW9znfDEsNSBfzY00my0nULMy2tPfmI9BXcyDc0IKNWjM2xsBX7FGUo2d5DwYaBGhkx8/ qnb+60P/QUjgD7U8xNCN4JJlubGH8YuirmTuWCpvcqxlsfkmvgkb8ZRfV8m7rTzrrM6HEZ 2LkoeaRVcUbnWDRjTJEix5ssAsfrJmFEFHwOFs99GE86rWBbu6O5CL3UD/RoTt1A0QGMvj Ehi+yGk94yCEfk4QMlW4Yj+jmnv1knQeuWtIyR61TU52cV8yE6oZlT2YiCGHrQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=puN48DGQ; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qSXa0-0003po-No; Sun, 06 Aug 2023 02:49:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSXZt-0003pW-NO for emacs-orgmode@gnu.org; Sun, 06 Aug 2023 02:49:26 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSXZr-00006G-FO for emacs-orgmode@gnu.org; Sun, 06 Aug 2023 02:49:25 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 14D1B240101 for ; Sun, 6 Aug 2023 08:49:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1691304560; bh=5c33w0ND+cKs+r8AUfC6sWf4HFoTe+qKcrqDwT+k+UQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=puN48DGQh19XNsIDZj65x81Q0mV6Hva6X2BaqHqz6qrvsEiMeut23i3jM+zXrIIxa zkjgeNlUN/D8kOuCCr6fHnAVw04mLAXWcBQ/QZ23HvtinIdkQfZQw7nxWTs76WKk9v QmMJDz/JCfSEKEXt2YHQjieVjvP9kklt6BMXz9jJQ/NrikRwExD8t59N3rAMmUGySP FEgj70lW0oQAyuCpYpgX2tz4yskbVb4Byta9Gjb33QbpISAP+uMPjL2rdrP0RKyaZf Wtn26iu0qTrJN2933nFXsRABLlSLGa5iqmvcXt0pALVduYNRozNJjTuC4/ddPRDXjE v/QEHBXzlai3w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RJVRg3jsyz9rxG; Sun, 6 Aug 2023 08:49:19 +0200 (CEST) From: Ihor Radchenko To: Roshan Shariff Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] org-macs: Fix incorrect use of relative paths in org-compile-file In-Reply-To: References: <20230805051842.142048-1-roshan.shariff@gmail.com> <87bkfllrcw.fsf@localhost> Date: Sun, 06 Aug 2023 06:49:44 +0000 Message-ID: <87zg34is1j.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -8.73 X-Migadu-Scanner: mx2.migadu.com X-Migadu-Queue-Id: E2EAD4A9E6 X-Spam-Score: -8.73 X-TUID: F5kiCAtRTmCK Roshan Shariff writes: > Thanks for the feedback! I'm attaching a new version of the patch that > improves the commit message and avoids the use of file-name-concat. Thanks! Applied, onto main, with minor amendments. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=4ea9a98f8 I added a TINYCHANGE cookie as you do not appear to have FSF copyright assignment. I also duplicated your comment about "pwd" usage to `org-compile-file' to avoid accidental edits in future. Please note that your total contribution have now exceeded the allowed limit we can accept without copyright paper work. You may consider FSF copyright assignment in future. See https://orgmode.org/worg/org-contribute.html#copyright -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at