From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id AEKOJVAOb2W1NwAAG6o9tA:P1 (envelope-from ) for ; Tue, 05 Dec 2023 12:49:36 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id AEKOJVAOb2W1NwAAG6o9tA (envelope-from ) for ; Tue, 05 Dec 2023 12:49:36 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0A1CC630AD for ; Tue, 5 Dec 2023 12:49:35 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=WY0Gm89t; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1701776976; a=rsa-sha256; cv=none; b=ibaa415BCf5NcnCvUYc84nnA+HRH9jj2RalWcW07qTc6nAkpQeABfrli5iYdlZGbM2+0dY U5MlqOWACUlUZco+uXWVhGAbyk2ivrjSLZ6gRASlfj7BUBjGrU25JGOtTff4uSUXanfQtJ q9k1RC2wybgKqHV5VZqVfyftMJg/14dB++K78T3OkOuz8GrHiBtn2E6qYZzG9sfMNhf8CM bMWjSG/rLukYbPgiK8TFN0zyMptDyyYAnvnQPSP45i+YY4mOSP/azI3C1YDhO2IY16HsjG 5IYUdeAJiEn25dzpKIyBv1a+/sopbiYBGtjlkKMgfGVRGiaIRV4mZTrO5tUotg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=WY0Gm89t; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1701776976; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=F8MOPLEvEyX3IljXzxczMk5nTlF/yTUCGy/HpW0PyYI=; b=LODArSmrrUBuvSptYs5vFIEoLHIq/I6GYs/sLbWx4rlwnPFRWVH2iBoDchkJlQoMabBXAK drR1Ut0AoKD/wxJvT0BRmICKEor0hWxfekhJ+RkjrxDkuC8RXNCDm350aBrNZq2r60xmPR rIn0WbRJQ9UJp+o4VtfT7ZHBqy5MbIx0hb+BxyrOgUU8nvonANqn6pZ7/YcQg4jZs+plWV 6G64eQP9VVOWUnBNt01Fq2/5UFp6vNQkXgdoh5K4VBTECJIJ5vJKFcMl+IICEQmh1ZeLbJ 8YJdDG4FBly3ed1jm0IJIXiXe/z6dNLciOPRTMUmzzYTPj8Eld+tmEF8gBZnDw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rATuv-0002K4-H5; Tue, 05 Dec 2023 06:48:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rATut-0002JV-0c for emacs-orgmode@gnu.org; Tue, 05 Dec 2023 06:48:43 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rATuq-00012r-Uu for emacs-orgmode@gnu.org; Tue, 05 Dec 2023 06:48:42 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 5C10C240027 for ; Tue, 5 Dec 2023 12:48:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1701776918; bh=GXEZPHdfFfzWa7GgYr2dCRteedHoTgw5Y3Px1VIkgfE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=WY0Gm89tDx7fGjFGrlyW758vPvQwm0p0E6YzZHwrY1GvgA8HPtTlHh4wOwT8ziITq gNPqHq/VhzF2D44pJdCLSqlngYwfMKOWgA0JrCQL4BMQJ/DqxGz8o9/WmtILfilLmi Fshthlv5OT3fn9zOiiaLEegakR29RWT8IEuvFYdMDi3ZKIxMfB6g3Qv49viNZLfDrH dsy5vGNYdVBby2/WiLbPMD9W9xMskMFnkhj3qrQGTVBpzHTyxv8h7Z8GAtYfifsf3X UzHifvtjvoq3JUo2ikSaNwfJ+dwp88a23K2Z9EAv4MZbIgCgMbrUKC/LDDa0HpGApw Xd6ffQT/RgJKg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SkzM93ksSz6ty7; Tue, 5 Dec 2023 12:48:37 +0100 (CET) From: Ihor Radchenko To: Liu Hui Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Set Python shell in Org edit buffer In-Reply-To: References: Date: Tue, 05 Dec 2023 11:51:36 +0000 Message-ID: <87zfyosw8n.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -9.34 X-Spam-Score: -9.34 X-Migadu-Queue-Id: 0A1CC630AD X-TUID: QsBKHWVxR29s Liu Hui writes: > When editing python src block using C-c ', the python shell is not set > in Org edit buffer according to the :session header argument of the > block. Consequently, commands such as python-shell-send-region cannot > send python code to the correct python process. To address this, the > attached patch defines org-babel-edit-prep:python in ob-python.el. Makes sense. I think we may drop a note about this new feature in ORG-NEWS. > In addition, I tried to use org-src-associate-babel-session at first, > but found it doesn't work because it is called when enabling > org-src-mode, where org-src--babel-info is still nil. It seems it has > stopped working since 203bf5870, and I think it is safe to remove it > and related stuffs to avoid confusion. I do not see it being used much, except https://github.com/frederic-santos/ob-ess-julia and https://github.com/alphapapa/outshine Although, ob-ess-julia is deprecated and outshine only mentions this in "TODO" comment. To be safe, I'd prefer to mark `org-src-associate-babel-session' obsolete and mention the removal in ORG-NEWS, pointing users to `org-babel-edit-prep:..' instead. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at