emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Lin Jian <me@linj.tech>
To: emacs-orgmode@gnu.org
Subject: [BUG] What about excluding .dir-locals.el from GNU ELPA tarball?
Date: Fri, 13 Sep 2024 07:07:26 +0800	[thread overview]
Message-ID: <87zfocwjwx.fsf@linj.tech> (raw)


Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     https://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------

Dear Org maintainers,

Currently, the .dir-locals.el file is included in the GNU ELPA
tarball[1], which causes this compilation error[2] when doing AOT native
compilation for Emacs lisp packages in NixOS.

Error: wrong-type-argument ("/nix/store/<hash>-emacs-org-9.7.10/share/emacs/site-lisp/elpa/org-9.7.10/.dir-locals.el" proper-list-p (org-edit-src-content-indentation . 0))
  mapbacktrace(#f(compiled-function (evald func args flags) #<bytecode -0xf42c55d2510e41>))
  debug-early-backtrace()
  debug-early(error (wrong-type-argument "/nix/store/<hash>-emacs-org-9.7.10/share/emacs/site-lisp/elpa/org-9.7.10/.dir-locals.el" proper-list-p (org-edit-src-content-indentation . 0)))
  signal(wrong-type-argument ("/nix/store/<hash>-emacs-org-9.7.10/share/emacs/site-lisp/elpa/org-9.7.10/.dir-locals.el" proper-list-p (org-edit-src-content-indentation . 0)))
  comp--native-compile("/nix/store/<hash>-emacs-org-9.7.10/share/emacs/site-lisp/elpa/org-9.7.10/.dir-locals.el")
  batch-native-compile()
  command-line-1(("--eval" "(setq large-file-warning-threshold nil)" "--eval" "(setq byte-compile-error-on-warn nil)" "-f" "batch-native-compile" "/nix/store/<hash>-emacs-org-9.7.10/share/emacs/site-lisp/elpa/org-9.7.10/.dir-locals.el"))
  command-line()
  normal-top-level()
Wrong type argument: "/nix/store/<hash>-emacs-org-9.7.10/share/emacs/site-lisp/elpa/org-9.7.10/.dir-locals.el", proper-list-p, (#<symbol org-edit-src-content-indentation at 304> . 0)

We can workaround this by skipping native compilation for
.dir-locals.el.  However, I do not think .dir-locals.el has to be
included in the GNU ELPA tarball.  In addition, MELPA ignores[3] that
file by default.

Could you exclude .dir-locals.el from GNU ELPA tarball?  FYI,
:ignored-files[4] of GNU ELPA specification can be used to do this.

[1]: https://elpa.gnu.org/packages/org-9.7.11.tar
[2]: https://hydra.nixos.org/build/271406205/nixlog/1
[3]: https://github.com/melpa/melpa/blob/0c608bf895a3b5230b781662510e1326af17ea13/README.md?plain=1#L169-L170
[4]: https://git.savannah.gnu.org/cgit/emacs/elpa.git/tree/README?id=51936a29b693bfc5f4f92e365b485a7c547b2ac1#n175

Best wishes,
Lin Jian

next             reply	other threads:[~2024-09-12 23:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-12 23:07 Lin Jian [this message]
2024-09-15  8:23 ` [BUG] What about excluding .dir-locals.el from GNU ELPA tarball? Ihor Radchenko
2024-09-15 16:58   ` Morgan Willcock
2024-09-16 19:22     ` Ihor Radchenko
2024-09-17 18:13       ` Morgan Willcock
2024-09-22  8:14         ` Ihor Radchenko
2024-09-16  0:58   ` Lin Jian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfocwjwx.fsf@linj.tech \
    --to=me@linj.tech \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).