From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tassilo Horn Subject: Re: [Bug] Slightly wrong org-tag fontification in agenda Date: Fri, 12 Feb 2010 20:29:39 +0100 Message-ID: <87y6iyuuak.fsf@thinkpad.tsdh.de> References: <87d40a8u7o.fsf@thinkpad.tsdh.de> <92220325-DA7F-4020-9666-35CE689C3439@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ng1DL-0003b5-P9 for emacs-orgmode@gnu.org; Fri, 12 Feb 2010 14:30:07 -0500 Received: from [140.186.70.92] (port=54493 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ng1DL-0003aT-50 for emacs-orgmode@gnu.org; Fri, 12 Feb 2010 14:30:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ng1DK-0004Oi-AW for emacs-orgmode@gnu.org; Fri, 12 Feb 2010 14:30:06 -0500 Received: from lo.gmane.org ([80.91.229.12]:39612) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ng1DJ-0004Oa-Vv for emacs-orgmode@gnu.org; Fri, 12 Feb 2010 14:30:06 -0500 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Ng1DJ-0004qi-8n for emacs-orgmode@gnu.org; Fri, 12 Feb 2010 20:30:05 +0100 Received: from p54af2225.dip0.t-ipconnect.de ([84.175.34.37]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 12 Feb 2010 20:30:05 +0100 Received: from tassilo by p54af2225.dip0.t-ipconnect.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 12 Feb 2010 20:30:05 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --=-=-= Carsten Dominik writes: Hi Carsten, > Yes, I think it is fixed now. Nearly, now the first colon isn't fontified. Here's a patch. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Don-t-omit-the-first-colon-when-fontifying-tags.patch >From 00d7a2bab8c5077eae99760c5f62dd09f4c363a4 Mon Sep 17 00:00:00 2001 From: Tassilo Horn Date: Fri, 12 Feb 2010 20:27:49 +0100 Subject: [PATCH] Don't omit the first colon when fontifying tags. --- lisp/ChangeLog | 5 +++++ lisp/org-agenda.el | 2 +- 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 31f5fc0..998d541 100755 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2010-02-12 Tassilo Horn + + * org-agenda.el (org-agenda-align-tags): Don't omit the first + colon when fontifying tags. + 2010-02-12 Carsten Dominik * org.el (org-get-location): Make sure the selection buffer is diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index 21c605f..5a63e47 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -6376,7 +6376,7 @@ If FORCE-TAGS is non nil, the car of it returns the new tags." (goto-char (match-beginning 1)) (insert (org-add-props (make-string (max 1 (- c (current-column))) ?\ ) - (plist-put (text-properties-at (point)) 'face nil)))) + (plist-put (text-properties-at (1- (point))) 'face nil)))) (goto-char (point-min)) (org-font-lock-add-tag-faces (point-max))))) -- 1.6.6.1 --=-=-= >> BTW: Is it really a good decision to propertize the text algorithmically >> in the functions building the agenda? I'm not sure, but it might be >> easier to define some `org-agenda-font-lock-keywords' like it's done for >> org files, too. > > That is a good question. I do, however, not believe that it would > be easy to define font lock keywords which can handle the agenda. > For example, when an item changes state, its face is changed, to > something with depends on where the item comes from and, for example, > how close the deadline is. And more stuff like that. > So font-lock regexp matching is now enough here. > Yes, it would be enough for tags, but not for other stuff. I see. Bye, Tassilo --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --=-=-=--