* [bug] alias for list-diary-entries-hook creates loop in emacs 24
@ 2012-01-11 8:56 Eric S Fraga
2012-01-11 9:41 ` d.tchin
0 siblings, 1 reply; 3+ messages in thread
From: Eric S Fraga @ 2012-01-11 8:56 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 613 bytes --]
Hello,
one of the recent updates
commit d6e40fb3472761ed51795f54491b969976167116
to org has caused a problem with the latest emacs snapshot (version from
5 January I believe). Specifically, the alias for
list-diary-entries-hook would appear to create an alias loop as
diary-lib.el in emacs already has an alias.
Removing two lines from org-agenda.el (patch attached) fixes the problem
(for me). I am not suggesting this as a patch as it would appear that
an emacs version specific check should probably be made? I don't know
enough about this to suggest a proper solution unfortunately.
thanks,
eric
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: remove var alias for list-diary-entries-hook --]
[-- Type: text/x-diff, Size: 565 bytes --]
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 28f5429..bdf6881 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -4378,8 +4378,6 @@ of what a project is and how to check if it stuck, customize the variable
(defvar org-disable-agenda-to-diary nil) ;Dynamically-scoped param.
(defvar diary-list-entries-hook)
-(if (fboundp 'defvaralias)
- (defvaralias 'diary-list-entries-hook 'list-diary-entries-hook))
(defvar diary-time-regexp)
(defun org-get-entries-from-diary (date)
"Get the (Emacs Calendar) diary entries for DATE."
[-- Attachment #3: Type: text/plain, Size: 131 bytes --]
--
: Eric S Fraga (GnuPG: 0xC89193D8FFFCF67D) in Emacs 24.0.90.1
: using Org-mode version 7.8.03 (release_7.8.03.75.g7e08.dirty)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [bug] alias for list-diary-entries-hook creates loop in emacs 24
2012-01-11 8:56 [bug] alias for list-diary-entries-hook creates loop in emacs 24 Eric S Fraga
@ 2012-01-11 9:41 ` d.tchin
2012-01-11 10:06 ` Eric S Fraga
0 siblings, 1 reply; 3+ messages in thread
From: d.tchin @ 2012-01-11 9:41 UTC (permalink / raw)
To: emacs-orgmode
Eric S Fraga <e.fraga <at> ucl.ac.uk> writes:
>
> Hello,
>
> one of the recent updates
>
> commit d6e40fb3472761ed51795f54491b969976167116
>
> to org has caused a problem with the latest emacs snapshot (version from
> 5 January I believe). Specifically, the alias for
> list-diary-entries-hook would appear to create an alias loop as
> diary-lib.el in emacs already has an alias.
>
> Removing two lines from org-agenda.el (patch attached) fixes the problem
> (for me). I am not suggesting this as a patch as it would appear that
> an emacs version specific check should probably be made? I don't know
> enough about this to suggest a proper solution unfortunately.
>
> thanks,
> eric
>
I think this bug is related to the correction of a bug I recently
submitted related to emacs 22.3. Please follow the link below :
http://article.gmane.org/gmane.emacs.orgmode/50960
Hope that can make help.
Regards
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [bug] alias for list-diary-entries-hook creates loop in emacs 24
2012-01-11 9:41 ` d.tchin
@ 2012-01-11 10:06 ` Eric S Fraga
0 siblings, 0 replies; 3+ messages in thread
From: Eric S Fraga @ 2012-01-11 10:06 UTC (permalink / raw)
To: d.tchin; +Cc: emacs-orgmode
d.tchin <d.tchin@voila.fr> writes:
> Eric S Fraga <e.fraga <at> ucl.ac.uk> writes:
>
>>
>> Hello,
>>
>> one of the recent updates
>>
>> commit d6e40fb3472761ed51795f54491b969976167116
>>
>> to org has caused a problem with the latest emacs snapshot (version from
>> 5 January I believe). Specifically, the alias for
>> list-diary-entries-hook would appear to create an alias loop as
>> diary-lib.el in emacs already has an alias.
>>
>
>> Removing two lines from org-agenda.el (patch attached) fixes the problem
>> (for me). I am not suggesting this as a patch as it would appear that
>> an emacs version specific check should probably be made? I don't know
>> enough about this to suggest a proper solution unfortunately.
>>
>> thanks,
>> eric
>>
>
> I think this bug is related to the correction of a bug I recently
> submitted related to emacs 22.3. Please follow the link below :
>
> http://article.gmane.org/gmane.emacs.orgmode/50960
>
> Hope that can make help.
>
>
>
> Regards
Indeed! I wrote my email on the train (off-line). By the time I got to
my office, the problem had been fixed! That's what I love about org.
Thanks,
eric
--
: Eric S Fraga (GnuPG: 0xC89193D8FFFCF67D) in Emacs 24.0.92.1
: using Org-mode version 7.8.03 (release_7.8.03.76.ga9c15)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-11 10:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-11 8:56 [bug] alias for list-diary-entries-hook creates loop in emacs 24 Eric S Fraga
2012-01-11 9:41 ` d.tchin
2012-01-11 10:06 ` Eric S Fraga
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).