From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Martyn Jago <martyn.jago@btinternet.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] Inconsistency in src block hiding
Date: Thu, 19 Jan 2012 20:18:54 +0100 [thread overview]
Message-ID: <87y5t34i1t.fsf@gmail.com> (raw)
In-Reply-To: <m2d3af3nbh.fsf@btinternet.com> (Martyn Jago's message of "Thu, 19 Jan 2012 12:10:26 +0000")
Hello,
Martyn Jago <martyn.jago@btinternet.com> writes:
> These changes /have/ caused a software regression, and should be
> reverted immediately, since:
>
> - they change current expected and implemented behavior to the cost of
> users expectations and current use, with no prior discussion and
> agreement on behavior changes
Surprisingly, I do remember discussing about this change not so long
ago. Thus, I think the "no prior discussion" is fallacious.
To sum it up, in that discussion, I had suggested that allowing to fold
keywords wasn't a good idea since:
1. Every element could get a #+name keyword, so everything would be
eventually foldable (and think about the mess to unfold piece-wise,
or everything).
2. Drawers would have consequently no more purpose (properties drawer
excepted).
> It has been proven that to achieve the required consistency set out by
> this thread /without/ breaking current expectations is less than
> straight-forward, and the changes should therefore be moved to
> EXPERIMENTAL - at least until the changes are proven not to break
> current expectations.
>
> Much of org-mode is currently inconsistent - and while it is highly
> desirable to improve on that situation, it should not become the major
> decision to change code at the cost of regression - org-mode is a very
> practical system used successfully by lots of (very appreciative)
> people, and while all users appreciate bug fixes / enhancements in the
> fast-moving repository that is org-mode (thanks Carsten), clear
> regression such as this should be avoided in master at all costs.
As a side note, master isn't maint, which is the place for stability and
also bug fixing. On the other hand, if a change doesn't hit master
branch, it won't get enough testing.
Now, there is no regression here: it has never been specified that
"#+results" keywords must allow to fold code. Folding is about
headlines, blocks, drawers and, optionally, items. Period.
Relying on "#+keyword" folding is a mistake. It would be better to
improve and correct drawers export (one of the things I address in the
new exporter). I talked in this thread about drawers
rehabilitation. Reverting this change will postpone this goal or, worse,
bury it.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2012-01-19 19:20 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-20 10:00 [BUG] Inconsistency in src block hiding Nicolas Goaziou
2011-11-20 15:53 ` Eric Schulte
2011-11-20 19:33 ` Nicolas Goaziou
2011-11-21 18:24 ` Eric Schulte
2011-11-22 16:15 ` Eric Schulte
2011-11-22 18:19 ` Nicolas Goaziou
2011-11-22 23:23 ` Eric Schulte
2011-11-23 15:25 ` Nicolas Goaziou
2011-11-28 8:09 ` Eric Schulte
2011-12-11 13:53 ` Bastien
2011-12-11 14:08 ` Nicolas Goaziou
2011-12-11 16:25 ` Eric Schulte
2011-12-11 16:04 ` Eric Schulte
2011-12-11 17:04 ` Bastien
2012-01-17 2:26 ` Bernt Hansen
2012-01-17 17:49 ` Nicolas Goaziou
2012-01-17 17:59 ` Bernt Hansen
2012-01-18 10:45 ` Leo Alekseyev
2012-01-18 16:02 ` Rick Frankel
2012-01-18 16:19 ` Eric Schulte
2012-01-18 17:36 ` Nicolas Goaziou
2012-01-19 12:10 ` Martyn Jago
2012-01-19 14:48 ` Eric Schulte
2012-01-19 15:22 ` Rick Frankel
2012-01-19 19:18 ` Nicolas Goaziou [this message]
2012-01-19 14:41 ` Eric Schulte
2012-01-19 19:26 ` Nicolas Goaziou
2012-01-24 3:41 ` Eric Schulte
2012-01-24 4:23 ` Leo Alekseyev
2012-01-24 4:44 ` Jambunathan K
2012-01-24 7:59 ` Andreas Leha
2012-01-24 20:39 ` Nicolas Goaziou
2012-01-28 16:08 ` Nicolas Goaziou
2012-01-25 0:00 ` Nick Dokos
2012-01-25 2:23 ` Bernt Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5t34i1t.fsf@gmail.com \
--to=n.goaziou@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=martyn.jago@btinternet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).