From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Loury Subject: Re: [PATCH] Fix uncaught error when trying to open a link at point Date: Wed, 13 Feb 2013 17:39:31 +0100 Message-ID: <87y5es88xo.fsf@konixwork.incubateur.ens-lyon.fr> References: <87ehjmvxk7.fsf@konixwork.incubateur.ens-lyon.fr> <87bodpdskd.fsf@bzg.ath.cx> <87wqvtrxcp.fsf@konixwork.incubateur.ens-lyon.fr> <87pq1lrssp.fsf@konixwork.incubateur.ens-lyon.fr> <87vc9wutfw.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:51433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U5fOd-0005nh-Mu for emacs-orgmode@gnu.org; Wed, 13 Feb 2013 11:41:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U5fOT-0004RE-O1 for emacs-orgmode@gnu.org; Wed, 13 Feb 2013 11:41:23 -0500 Received: from mail-wi0-f171.google.com ([209.85.212.171]:44285) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U5fOT-0004R2-Hz for emacs-orgmode@gnu.org; Wed, 13 Feb 2013 11:41:13 -0500 Received: by mail-wi0-f171.google.com with SMTP id hn17so5966454wib.4 for ; Wed, 13 Feb 2013 08:41:12 -0800 (PST) In-Reply-To: <87vc9wutfw.fsf@bzg.ath.cx> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: OrgMode ML --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Bastien writes: >> It adjusts org-open-at-point to have plain links handled the same way >> bracket links are. It allows plain links to be followed if the cursor is >> before the link while still on the same line. By the way, the documentation of org-open-at-point says: =E2=95=AD=E2=94=80=E2=94=80=E2=94=80=E2=94=80 =E2=94=82 If there is no link at point, this function will search forward u= p to =E2=94=82 the end of the current line. =E2=95=B0=E2=94=80=E2=94=80=E2=94=80=E2=94=80 Then the patch not only makes the behavior consistent but it makes the implementation do what the documentation says. > > I applied a slightly modified version of your patch, condensing > comments. See the change here: > > http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=3D9964d8 > I like it. It passes the tests and looks good for me. > Thanks, I am sorry for not sending the full patch myself: I am still waiting for the documents indicating I can contribute to emacs. =2D-=20 Konubinix GPG Key : 7439106A Fingerprint: 5993 BE7A DA65 E2D9 06CE 5C36 75D2 3CED 7439 106A --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQEcBAEBAgAGBQJRG8HEAAoJEHXSPO10ORBqZ0kIAJSUZYGQxHsvlz5CXzlF/6NK gIrUhmG/57lcywrHzJjSlCgqj5isB9KbGPJlJScfJt0M+eKYklfD/sZYa3u+SZbU X0WcEdGKYub4OCuFI/kOBAduXg4e0stpYIlzyNNEXUcgB6Dq41LU+RkIgoKZdzBO UGPCKSPKfK5Gha/Lk8yzS2oGOkcO5AYi5k/9Fmmr8oo4hmiK7Vh90u05ayFgR68X pmrsjknYfEmoomtDa43DEZqGxD1st5h4UPsZMT3bdZ7jbNnRO4y/Fv/nsY5vbwRM HLQKHFsgPY9Jr059FcywD54gMXe8dhDmq4eoiHpTpBx6AkUQsZW6QPQwEGPJpOg= =mai2 -----END PGP SIGNATURE----- --=-=-=--