emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Samuel Loury <konubinix@gmail.com>
To: Bastien <bzg@altern.org>
Cc: OrgMode ML <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Fix uncaught error when trying to open a link at point
Date: Wed, 13 Feb 2013 17:39:31 +0100	[thread overview]
Message-ID: <87y5es88xo.fsf@konixwork.incubateur.ens-lyon.fr> (raw)
In-Reply-To: <87vc9wutfw.fsf@bzg.ath.cx>

[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]

Bastien <bzg@altern.org> writes:

>> It adjusts org-open-at-point to have plain links handled the same way
>> bracket links are. It allows plain links to be followed if the cursor is
>> before the link while still on the same line.

By the way, the documentation of org-open-at-point says:

│ If there is no link at point, this function will search forward up to
│ the end of the current line.

Then the patch not only makes the behavior consistent but it makes the
implementation do what the documentation says.

> I applied a slightly modified version of your patch, condensing
> comments.  See the change here:
> http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=9964d8

I like it. It passes the tests and looks good for me.

> Thanks,

I am sorry for not sending the full patch myself: I am still waiting for
the documents indicating I can contribute to emacs.

GPG Key    : 7439106A
Fingerprint: 5993 BE7A DA65 E2D9 06CE  5C36 75D2 3CED 7439 106A

[-- Attachment #2: Type: application/pgp-signature, Size: 489 bytes --]

  reply	other threads:[~2013-02-13 16:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-22  8:42 [PATCH] Fix uncaught error when trying to open a link at point Samuel Loury
2012-11-28 12:53 ` Nicolas Goaziou
2012-12-20  8:41 ` Bastien
2013-01-04 11:39   ` Samuel Loury
2013-01-04 13:17     ` Samuel Loury
2013-01-04 16:18       ` Bastien
2013-01-14 10:35         ` Samuel Loury
2013-02-13 15:25       ` Bastien
2013-02-13 16:39         ` Samuel Loury [this message]
2013-02-13 16:49           ` Bastien
2013-03-16 19:22             ` Samuel Loury
2013-03-16 19:32               ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y5es88xo.fsf@konixwork.incubateur.ens-lyon.fr \
    --to=konubinix@gmail.com \
    --cc=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).