From: aaronecay@gmail.com
To: Nicolas Goaziou <n.goaziou@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ox-latex: provide width and height options for images
Date: Tue, 05 Mar 2013 23:02:05 -0500 [thread overview]
Message-ID: <87y5e189c2.fsf@gmail.com> (raw)
In-Reply-To: <87621etban.fsf@gmail.com>
2013ko otsailak 27an, Nicolas Goaziou-ek idatzi zuen:
> Thank you for your patch. Here are a few comments.
Thank you for the comments! I think the patch is simpler and better
thanks to them.
>
>> These are implemented with \resizebox, and thus are uniform across
>> different types of image inclusion (\includegraphics, \input of tikz
>> images). This differs from the older way of using width and height
>> optional args to \includegraphics.
>
> I tend to agree with Rasmus. It would be better to keep height and
> width options in \includegraphics when possible.
Okay.
>
>> Thus, the default value for org-latex-image-default-options is left
>> untouched, to avoid breaking compatibility with older code. After a
>> transition period, the 0.9\linewidth value should be moved into
>> org-latex-image-default-width, and the -options variable set to the
>> empty string.
>
> We don't need this precaution. The exporter code for 8.0 introduced
> many incompatibilities already. Also, this one is easy to discover.
Okay.
>
> I think it's a good step forward. It will need to be documented in the
> comments at the beginning of ox-latex.el, where all attributes
> properties relative to different syntactical elements are explained.
Okay – see what you think of the documentation in the new patch.
>
> Here, you can obtain \resizebox{!}{!}{%s}, which is wrong, isn't it?
No...it is a no-op. That said, the code should no longer do this.
>
> This needs to be changed as these options would interfere with :width
> argument. For example, (eq float 'float) could set :width property if
> it is undefined. Obviously, this means the check has to be done before
> WIDTH and HEIGHT strings are built.
This should now be handled. The new patch will follow this email. In
related news, I have completed the FSF copyright assignment process, so
the patch can be merged whenever it is deemed ready.
Thanks again,
--
Aaron Ecay
next prev parent reply other threads:[~2013-03-06 4:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-24 18:51 [PATCH] ob-R.el, ox-latex.el: support for tikz graphics Aaron Ecay
2013-02-25 15:19 ` Nicolas Goaziou
2013-02-26 10:50 ` Achim Gratz
2013-02-26 12:25 ` Myles English
2013-02-26 13:21 ` Nicolas Goaziou
2013-02-26 14:33 ` Achim Gratz
2013-02-26 19:21 ` Aaron Ecay
2013-02-26 19:22 ` [PATCH] ox-latex: provide width and height options for images Aaron Ecay
2013-02-26 23:04 ` Rasmus
2013-02-27 2:02 ` Aaron Ecay
2013-02-27 18:40 ` Achim Gratz
2013-02-27 8:23 ` Nicolas Goaziou
2013-03-06 4:02 ` aaronecay [this message]
2013-03-06 4:04 ` [PATCH] ox-latex: Support tikz images, :width, and :height Aaron Ecay
2013-03-06 8:35 ` [PATCH] ox-latex: provide width and height options for images Nicolas Goaziou
2013-02-26 18:25 ` [PATCH] ob-R.el, ox-latex.el: support for tikz graphics Achim Gratz
2013-02-26 19:49 ` Aaron Ecay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5e189c2.fsf@gmail.com \
--to=aaronecay@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=n.goaziou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).