emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [patch] LaTeX export using tabu tables
Date: Mon, 25 Mar 2013 20:59:38 +0100	[thread overview]
Message-ID: <87y5dbxnbp.fsf@gmail.com> (raw)
In-Reply-To: <878v5cdotv.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 25 Mar 2013 13:35:08 +0800")

Hello,

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> I was trying to be too clever! Attached is a non-clever version that
> includes a :spread keyword, and a (hopefully) correctly-written commit
> message.

Nice. A few more comments follow.

> Subject: [PATCH 8/8] ox-latex.el (org-latex--org-table, org-latex-table-row):
>  Allow use of the "tabu" table environment when exporting tables to
> LaTeX.

Actually the first line of the commit should be more general (and
shouldn't end with a full stop). Perhaps something like:

  ox-latex: Allow use of "tabu" table environment

> * ox-latex.el (org-latex--org-table): New latex export attribute
>   :spread accommodates weird width specification syntax of the tabu
>   package.

I would drop a note about the "tabu" and "longtabu" support in the
description of the patch.

> +;; - `:spread' is a boolean attribute specific to the "tabu" and
> +;;   "longtabu" environments, and only takes effect when used in
> +;;   conjunction with the `:width' attribute. When `:spread' is

Nitpick: Emacs documentation and comments require two spaces after
a sentence.

> +	 (spread (plist-member attr :spread))

I think you mean (plist-get attr :spread), otherwise ":spread nil" will
still activate spread. Also, since it's a predicate, I suggest to name
the variable "spreadp".

>  	 (placement (or (plist-get attr :placement)
>  			(format "[%s]" org-latex-default-figure-position)))
>  	 (centerp (if (plist-member attr :center) (plist-get attr :center)
> @@ -2460,6 +2467,23 @@ This function assumes TABLE has `org' as its `:type' property and
>  		   (concat caption "\\\\\n"))
>  	      "\\end{longtable}\n"
>  	      (and fontsize "}")))
> +     ;; Longtabu
> +     ((equal "longtabu" table-env)
> +      (concat (and fontsize (concat "{" fontsize))
> +	      (format "\\begin{longtabu}%s{%s}\n"
> +		      (if width
> +			(format " %s %s "
> +				(if spread "spread" "to") width) "")
> +		      alignment)
> +	      (and org-latex-table-caption-above
> +		   (org-string-nw-p caption)
> +		   (concat caption "\\\\\n"))
> +	      contents
> +	      (and (not org-latex-table-caption-above)
> +		   (org-string-nw-p caption)
> +		   (concat caption "\\\\\n"))
> +	      "\\end{longtabu}\n"
> +	      (and fontsize "}")))
>       ;; Others.
>       (t (concat (cond
>  		 (float-env
> @@ -2471,7 +2495,10 @@ This function assumes TABLE has `org' as its `:type' property and
>  		 (fontsize (concat "{" fontsize)))
>  		(format "\\begin{%s}%s{%s}\n%s\\end{%s}"
>  			table-env
> -			(if width (format "{%s}" width) "")
> +			(if width (format
> +				   (if (equal "tabu" table-env)
> +				       (if spread " spread %s " " to %s")
> +				     "{%s}") width) "")

"longtabu" gets its own cond branch, but not "tabu". I think that
defeats the purpose of the separation, which is to be able to add
support for features of this rich table environment without cluttering
the rest of the code. Doing it partially isn't worth the code
duplication it implies.

IOW, either we separate both "tabu" and "longtabu" completely, or we
separate none of them. Your call.


Thank you again.


Regards,

-- 
Nicolas Goaziou

  parent reply	other threads:[~2013-03-25 19:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-23  4:26 [patch] LaTeX export using tabu tables Eric Abrahamsen
2013-03-24  0:18 ` Vikas Rawal
2013-03-24  9:26 ` Nicolas Goaziou
2013-03-25  5:35   ` Eric Abrahamsen
2013-03-25  5:54     ` Bastien
2013-03-25  6:54       ` Eric Abrahamsen
2013-03-25  6:51         ` Bastien
2013-03-25 19:59     ` Nicolas Goaziou [this message]
2013-03-26  2:54       ` Eric Abrahamsen
2013-03-27 14:29         ` Nicolas Goaziou
2013-03-26 20:05     ` Marcin Borkowski
2013-03-27  1:59       ` Eric Abrahamsen
2013-04-07 13:15         ` Marcin Borkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y5dbxnbp.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=eric@ericabrahamsen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).