emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Rasmus <rasmus@gmx.us>
To: n.goaziou@gmail.com
Cc: emacs-orgmode@gnu.org
Subject: Re: [ox-latex] Bad default value for image width?
Date: Wed, 10 Apr 2013 13:52:08 +0200	[thread overview]
Message-ID: <87y5cqiown.fsf@pank.iue.private> (raw)
In-Reply-To: <8761zv9xd0.fsf@gmail.com> (Nicolas Goaziou's message of "Wed, 10 Apr 2013 00:02:03 +0200")

Nicolas,

>> I don't like that tikz figures are wrapped in a resize box.  
>
> Set `org-latex-image-default-width' to "".

But as my second email shows this still doesn't work with
captions. . .

This exmample:

#+BEGIN_SRC org
#+BEGIN_SRC emacs-lisp
(make-local-variable 'org-latex-image-default-width)
(setq org-latex-image-default-width "")
#+END_SRC

#+NAME:firm-ts-fig
#+CAPTION: test
[[file:figs/test.tikz]]

no caption
[[file:figs/test.tikz]]
#+END_SRC

> That's not correct. It is always true because (:width "") means width
> becomes "\"\"", not "". IOW, `org-export-read-attribute' is unable to
> parse a real empty string.

I see. 

> This wouldn't help to solve the general problem. Though, you can change
> it in your config to something else, as suggested above.

I have.  But I don't think it's a sensible default.  It's against what
your usual stand of Org not trying to be too clever.  You would also
not put tables in resize boxes to make them "fit" on the page.


Here's another example where the default causes a non-sensible
behavior.

#+BEGIN_SRC org
#+BEGIN_SRC emacs-lisp :exports none
(url-copy-file "http://orgmode.org/img/org-mode-unicorn-logo.png" "logo.png")
#+END_SRC

* My raster picture

This is a low res. picture with the right size^{TM}

[[file:logo.png]]
#+END_SRC


>>   2. allow for a non-width (:width nil)
>>   3. make a better test for the resize box.
>>
>> Let me know and I might be able to look into it.



> I think the correct solution would be to fix `org-export-read-attribute'
> so it can read empty strings.

I think this is the solution to a general problem.  But I still find
the default width to be wrong.  It only works as intended when I have
a slightly too large picture.  And then, if anything, I'd want full
page width.  

It's a bad default for
  - Picture smaller than textwidth
  - Picture crafted to the document which shouldn't have a width.

It's a decent solution for 
  - pictures which are unintentionally larger than textwidth.  But IMO
    it's my responsibility, and not Org's, to fix these
    images/situations.


In usually exhibit good judgment of these matters, so I'll take your
word for it.  But I fail to see its usefulness as a default.

> If "" is really read as "", """" will still be read as "\"\"\"\"", and
> it will not be possible to obtain "\"\"".

Fine with me. 

> Another possibility is to read the empty string as the empty string
> instead of nil, that is
>
>   #+attr_latex: :prop1 :prop2 1

I like the "" better.  It works better with my "intuitive logic".


–Rasmus


-- 
Hvor meget poesi tror De kommer ud af et glas isvand?

  reply	other threads:[~2013-04-10 11:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-07 20:17 [ox-latex] Bad default value for image width? Rasmus
2013-04-07 20:38 ` Rasmus Pank Roulund
2013-04-08 19:35 ` Bastien
2013-04-09 21:08   ` Nicolas Goaziou
2013-04-09 21:30     ` Bastien
2013-04-09 22:02 ` Nicolas Goaziou
2013-04-10 11:52   ` Rasmus [this message]
2013-04-10 16:53     ` Nicolas Goaziou
2013-04-10 17:23       ` Rasmus
2013-04-10 20:13         ` Nicolas Goaziou
2013-04-11 15:36           ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y5cqiown.fsf@pank.iue.private \
    --to=rasmus@gmx.us \
    --cc=emacs-orgmode@gnu.org \
    --cc=n.goaziou@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).