From: Bastien <bzg@gnu.org>
To: Ross Patterson <me@rpatterson.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Add a flat clocktable formatter useful for tables whose CSV export can be imported into accounting/invoiving tools such as Zoho Invoicing.
Date: Sun, 30 Jun 2013 22:25:56 +0200 [thread overview]
Message-ID: <87y59rrzsi.fsf@bzg.ath.cx> (raw)
In-Reply-To: <87vc4x3by1.fsf@rpatterson.net> (Ross Patterson's message of "Fri, 28 Jun 2013 19:09:10 -0700")
Hi Ross,
Ross Patterson <me@rpatterson.net> writes:
> Bastien <bzg@gnu.org> writes:
>
>> thanks for the patch. Do you mind filling the copyright
>> assignment so we can accept the patch ?
>
> I already have an FSF Emacs Assignment from 2008-12-22, RT 393650. Is
> there something else I need to do?
Nope. I didn't know you had a FSF assignment.
That said, the patch looks more like an add-on to Org for a very
specific use, so putting this code in contrib/ would be better.
Also, `org-clock-clocktable-flat-columns' defines some customizable
values that are hardcoded in `org-clocktable-write-flat'. Either the
values should not be customizable, or the `org-clocktable-write-flat'
should call them differently? Just a suggestion.
>> http://orgmode.org/cgit.cgi/org-mode.git/plain/request-assign-future.txt
>>
>> Also, please have a look at this page with guidance on how
>> to submit a patch with a ChangeLog etc.
>>
>> http://orgmode.org/worg/org-contribute.html#sec-4-2
>
> I did a search for such docs on orgmode.org but only found a pointer to
> the list. Perhaps someone should make these links more obvious.
I promoted the org-contribute.html page in the homepage of Org,
thanks for bringing this up!
--
Bastien
prev parent reply other threads:[~2013-06-30 22:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 4:20 [PATCH] Add a flat clocktable formatter useful for tables whose CSV export can be imported into accounting/invoiving tools such as Zoho Invoicing Ross Patterson
2013-06-28 7:03 ` Bastien
2013-06-29 2:09 ` Ross Patterson
2013-06-30 20:25 ` Bastien [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y59rrzsi.fsf@bzg.ath.cx \
--to=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=me@rpatterson.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).