emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Markus Hauck <markus1189@gmail.com>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix: allow org-refile in goto mode from everywhere
Date: Mon, 21 Apr 2014 19:59:32 +0200	[thread overview]
Message-ID: <87y4yy7ed7.fsf@gmail.com> (raw)
In-Reply-To: <87oazwsfi8.fsf@bzg.ath.cx>

[-- Attachment #1: Type: text/plain, Size: 822 bytes --]


Hi Bastien,

I think you're right, sorry for any inconveniences ;)

Bastien <bzg@gnu.org> writes:

> Hi Markus,
>
> Markus Hauck <markus1189@gmail.com> writes:
>
>> It seems like org-refile with the goto argument is no longer allowed
>> From non org-mode buffers.
>
> I reverted your patch.
>
>> In commit 49da67d the condition was changed from:
>>
>> (unless goto ...)
>>
>> to:
>>
>> (unless (and goto (listp goto)) ...)
>>
>> where the condition of unless is only true for non-empty lists.
>
> That's in fact on purpose.  If you want to use org-refile to go to
> a location, use (org-refile '(4)), the '(4) emulates the universal
> prefix argument.  Note that
>
> With your patch, the prompt for org-refile (as (org-refile nil))
> was asking "Goto: " because (listp nil) is `t'.
>
> Let me know if I missed something.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 489 bytes --]

      reply	other threads:[~2014-04-21 17:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-07 17:51 [PATCH] Fix: allow org-refile in goto mode from everywhere Markus Hauck
2014-04-11 10:00 ` Bastien
2014-04-20  6:04 ` Bastien
2014-04-21 17:59   ` Markus Hauck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y4yy7ed7.fsf@gmail.com \
    --to=markus1189@gmail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).