From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Abrahamsen Subject: Re: [RFC] Display most recent log item in Agenda Date: Sun, 14 Dec 2014 23:12:07 +0800 Message-ID: <87y4qal0zc.fsf@ericabrahamsen.net> References: <87388imto5.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0Ako-00007z-HR for emacs-orgmode@gnu.org; Sun, 14 Dec 2014 10:06:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0Akh-0000Rw-BE for emacs-orgmode@gnu.org; Sun, 14 Dec 2014 10:06:38 -0500 Received: from plane.gmane.org ([80.91.229.3]:51508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0Akh-0000Rl-3v for emacs-orgmode@gnu.org; Sun, 14 Dec 2014 10:06:31 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Y0Akg-0001pT-69 for emacs-orgmode@gnu.org; Sun, 14 Dec 2014 16:06:30 +0100 Received: from 222.128.163.127 ([222.128.163.127]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 14 Dec 2014 16:06:30 +0100 Received: from eric by 222.128.163.127 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 14 Dec 2014 16:06:30 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Eric Abrahamsen writes: > Undeterred by my previous bum patch, I'm sending more patches! > > Most of these are "what do you think" patches. > > 1. Ensure-org-log-into-drawer-returns-nil-or-string > > If the answer to my last question is "make sure `org-log-into-drawer' > never returns just t", then this patch does that. If that isn't the > answer, something can be done with `org-log-beginning'. Nope, I just shouldn't be posting patches today. One should not code while hungover. Fixed patch attached. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Ensure-org-log-into-drawer-returns-nil-or-string.patch >From c99d6065ae25d927a395f9aed611fab22b8e40c9 Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Sun, 14 Dec 2014 17:31:49 +0800 Subject: [PATCH 1/4] Ensure org-log-into-drawer returns nil or string * lisp/org.el (org-log-into-drawer): Don't let it simply return t. --- lisp/org.el | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lisp/org.el b/lisp/org.el index 4aa7988..db5810d 100755 --- a/lisp/org.el +++ b/lisp/org.el @@ -2969,7 +2969,11 @@ If the current entry has or inherits a LOG_INTO_DRAWER property, it will be used instead of the default value." (let ((p (org-entry-get nil "LOG_INTO_DRAWER" 'inherit t))) (cond - ((not p) org-log-into-drawer) + ((not p) + (when org-log-into-drawer + (if (stringp org-log-into-drawer) + org-log-into-drawer + "LOGBOOK"))) ((equal p "nil") nil) ((equal p "t") "LOGBOOK") (t p)))) -- 2.1.3 --=-=-= Content-Type: text/plain > 2. Missing-comma-in-org-agenda-with-point-at-orig-entry > > The (currently unused) macro `org-agenda-with-point-at-orig-entry' is > missing a comma. > > 3. New-function-org-get-log-list and > New-function-org-agenda-show-log-item > > This is the "what do you think part". The first patch finds and returns > the state log items of the current entry, as a list of parsed elements. > It probably doesn't try hard enough to make sure it's really found the > list. > > The second implements an Agenda command which displays the text of the > most recent note on the entry under point. I use logging a lot, and am > forever looking at "WAIT" or "NEXT" todos, and wondering what the heck I > was waiting for, or actually supposed to do next. > > If this is acceptable in principle, the finished product would probably > be a normal org-mode function, with an Agenda implementation on top of > that, and maybe some sort of guard against displaying overly-long notes. > > Alternately, I could probably make this into something akin to > org-agenda-entry-text-mode, where *all* entries have their most recent > log item stuck under them. I find that sort of thing distracting, but > some people might like it. > > WDYT? > > Eric --=-=-=--