From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thorsten Jolitz Subject: Re: Use of deprecated org-log-note-marker variable in outshine Date: Thu, 04 Feb 2016 00:02:41 +0100 Message-ID: <87y4b1gzxq.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aR6Rr-0002rn-H1 for emacs-orgmode@gnu.org; Wed, 03 Feb 2016 18:02:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aR6Rn-0007k8-D5 for emacs-orgmode@gnu.org; Wed, 03 Feb 2016 18:02:55 -0500 Received: from plane.gmane.org ([80.91.229.3]:33102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aR6Rn-0007k0-5j for emacs-orgmode@gnu.org; Wed, 03 Feb 2016 18:02:51 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1aR6Ri-0004YV-Mt for emacs-orgmode@gnu.org; Thu, 04 Feb 2016 00:02:46 +0100 Received: from f051039154.adsl.alicedsl.de ([78.51.39.154]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 04 Feb 2016 00:02:46 +0100 Received: from tjolitz by f051039154.adsl.alicedsl.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 04 Feb 2016 00:02:46 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Kaushal Modi writes: Hi Kaushal, > Recently the global variable org-log-note-marker was removed from > org.el. > > But it is used in outshine.el as follows: > > (defadvice org-store-log-note (around org-store-log-note-around > activate) > "Outcomment inserted log-note in Outshine buffers." > (let ((outshine-log-note-beg-marker > ;; stay before inserted text > (copy-marker org-log-note-marker nil)) > (outshine-log-note-end-marker > ;; stay after inserted text > (copy-marker org-log-note-marker t))) > ad-do-it > (unless (derived-mode-p 'org-mode 'org-agenda-mode) > (comment-region outshine-log-note-beg-marker > outshine-log-note-end-marker)) > (move-marker outshine-log-note-beg-marker nil) > (move-marker outshine-log-note-end-marker nil))) > > So right now, I am getting this warning at emacs startup: > > ~/.emacs.d/elpa_25_0/outshine-20151203.802/outshine.elc:Warning: > reference to > free variable ‘org-log-note-marker’ > > @ Thorsten, Nicolas: What would be the best way to fix that? > > My org version: > Org-mode version 8.3.2 (release_8.3.2-469-ga902c8 @ > /home/kmodi/usr_local/apps/6/emacs/emacs-25/share/emacs/site-lisp/org/) Thanks for the bug report. Sorry for beeing so late ... but maybe better late than never. I pushed a first fix to origin/trunk. The outcommenting of inserted log-notes in outshine seems to work again, but I encountered a new issue with comment-region: ,---- | ;; * WAITING foo | ;; - State "WAITING" from "TODO" [2016-02-03 Mi 23:46] \\ | ;; waiting for bar `---- It produces this now, which is no good, since outshine expects comments to start at beginning-of-line. I reported this on Emacs Help. Which Org-mode version is the first one with the new org-log-note-marker semantics (to make the advice in outshine conditional on that)? I push this to master once its really fixed. -- cheers, Thorsten