emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Justin Kirby <justinkirby@gmail.com>
Cc: emacs-org <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] add port switch for postgresql support in ob-sql.el
Date: Sun, 22 May 2016 23:47:17 +0200	[thread overview]
Message-ID: <87y471kboa.fsf@saiph.selenimh> (raw)
In-Reply-To: <878tz54o29.fsf@openaether.org> (Justin Kirby's message of "Thu, 19 May 2016 19:37:18 -0400")

Hello,

Justin Kirby <justinkirby@gmail.com> writes:

> I added a port switch for postgresql in ob-sql.el

Thank you for the patch. Some comments follow.

> I have attached a simple patch to fix this and have verified it works
> for me. I would have loved to add some tests, but I ran into some
> problems:
>
> 1) I could not figure out how to get just one test file to run
> 2) I was not able get make test to load the sql language in babel
>
>
> Is there a recommended/standard way to resolve these problems with
> tests?

See <http://orgmode.org/worg/dev/org-build-system.html>, in particular
BTEST_RE and BTEST_OB_LANGUAGES environment variables.

> From 4ca513afe3725fbfbefd7ad9bf54637adfd56ea2 Mon Sep 17 00:00:00 2001
> From: Justin Kirby <justin@redsorbet.com>
> Date: Wed, 18 May 2016 23:14:48 -0400
> Subject: [PATCH] add dbport parameter to postgresql dbstring

First letter should be upper case.

You also need to provide the name of the function being modified in the
commit message, e.g.

  lisp/ob-sql.el (org-babel-sql-dbstring-postgresql): Add PORT argument.
  (org-babel-execute:sql): Apply previous change.

I you haven't signed FSF papers, you also need to add TINYCHANGE at the
end of the commit message.

Could you send an updated patch ? Also, could you provide a short notice
in ORG-NEWS (located in doc/)?

Regards,

-- 
Nicolas Goaziou

     prev parent reply	other threads:[~2016-05-22 21:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-19 23:37 [PATCH] add port switch for postgresql support in ob-sql.el Justin Kirby
2016-05-22 21:47 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y471kboa.fsf@saiph.selenimh \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=justinkirby@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).