From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: How to keep correct filepaths when using the #+INCLUDE derivative? Date: Tue, 06 Mar 2018 09:51:05 +0100 Message-ID: <87y3j537uu.fsf@nicolasgoaziou.fr> References: <87woyxhuk2.fsf@nicolasgoaziou.fr> <87o9k7ir3i.fsf@nicolasgoaziou.fr> <87h8pzifk7.fsf@nicolasgoaziou.fr> <878tbahrxv.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1et8JR-0002z3-0p for emacs-orgmode@gnu.org; Tue, 06 Mar 2018 03:51:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1et8JQ-0000f2-0s for emacs-orgmode@gnu.org; Tue, 06 Mar 2018 03:51:09 -0500 Received: from relay2-d.mail.gandi.net ([2001:4b98:c:538::194]:42943) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1et8JP-0000eQ-Qq for emacs-orgmode@gnu.org; Tue, 06 Mar 2018 03:51:07 -0500 In-Reply-To: (Daniel P. Gomez's message of "Sat, 3 Mar 2018 14:06:05 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Daniel P Gomez Cc: emacs-orgmode@gnu.org Hello, Daniel P Gomez writes: > I noticed that (buffer-file-name (buffer-base-buffer)) will always > return nil because `org-export--prepare-file-contents` is called in > `org-export-include-keyword` after a call to `with-temp-buffer`. Two > possible solutions to this issue would be either 1. passing the > includer-file as an extra parameter to > `org-export--prepare-file-contents` and then using > `file-relative-name` to generate a relative path, or alternatively 2 . > passing the matched string that points to the file to be included. > Example: > > #+INCLUDE: "directory/file.org" > > Here, if file.org contains a link [[other/image.png]], then all one > has to do is append the (file-name-directory matched) to the old-path. > In this example this would result in directory/other/image.png. > > This second solution does not require a call to (buffer-file-name > (buffer-base-buffer)), but seems hackish in the sense that we would > pass 2 redundant arguments to `org-export-prepare-file-contents`: both > the expanded and the non-expanded include-file filename. > Perhaps I'm missing a simpler 3rd solution? I think solution 1 is fine. > If we opt for solution 1 then new-path could be made relative here >> ;; (org-element-put-property new :path new-path) > > (org-element-put-property > new :path > (if includer-file > (file-relative-name > new-path (file-name-directory includer-file)) > new-path)) Indeed. However, the (if includer-file ...) should be integrated in new-path binding, IMO. > I will attempt to write them once the implementation is completed. Great. Thank you! Regards, -- Nicolas Goaziou 0x80A93738