From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] add :session support for ob-js.el
Date: Sun, 25 Mar 2018 23:09:40 +0200
Message-ID: <87y3if9817.fsf@nicolasgoaziou.fr>
References: <4f31b760-06ac-5c32-8dbd-76f1017d3cd1@gmail.com>
	<87efko8iwr.fsf@nicolasgoaziou.fr>
	<307cac72-36e9-0ba6-262b-a12f291953a0@gmail.com>
	<87a7v7dkdp.fsf@nicolasgoaziou.fr>
	<366d0e08-8e60-88a2-f7e5-28db5ba3deb8@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49612)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1f0Cte-0000t6-0P
	for emacs-orgmode@gnu.org; Sun, 25 Mar 2018 17:09:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1f0Cta-0003Zu-Nt
	for emacs-orgmode@gnu.org; Sun, 25 Mar 2018 17:09:45 -0400
Received: from relay7-d.mail.gandi.net ([217.70.183.200]:46885)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1f0Cta-0003ZU-IW
	for emacs-orgmode@gnu.org; Sun, 25 Mar 2018 17:09:42 -0400
In-Reply-To: <366d0e08-8e60-88a2-f7e5-28db5ba3deb8@gmail.com> (stardiviner's
	message of "Sun, 25 Mar 2018 11:31:33 +0800")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: stardiviner <numbchild@gmail.com>
Cc: org-mode <emacs-orgmode@gnu.org>

Hello,

stardiviner <numbchild@gmail.com> writes:

> I attached my new generated patches.
>
>
> On 03/17/2018 07:14 PM, Nicolas Goaziou wrote:
>> Some comments follow.
>>> +	       (result (if (not (string= (cdr (assq :session params)) "none"))
>> You can integrate the test above in the `cond':
>>
>> (cond
>>   ((string= "none" (cdr (assq :session params))) nil)
>>   ((string= "*JS REPL*" session) ...)
>>   ...)
> This is modified in new patch.
>>> +	      (sit-for .5) (goto-char (point-max))
>> (sit-for .5)
>> (goto-char (point-max))
> This is in original code, might because ob-js initialize REPL backend
> need some time so original author added `site-for`. After test, this
> seems does not matter. So remote the sit-for now.
>>
>>> +	      (mapc (lambda (var)
>>> +		            (insert var) (comint-send-input nil t)
>>> +		            (org-babel-comint-wait-for-output session)
>>> +		            (sit-for .1) (goto-char (point-max))) var-lines)))
>>>       session))
>>    (dolist (var ...)
>>     ...)
> modified in new patch.
>
> I don't know how to apply master branch new update on my local
> `ob-js-session` branch so to get ob-js related commits on top to
> generate new patches. (Do you have any idea on this?) The new patches
> are behind latest `master` branch. But should be compatible still. If
> generating patches based on latest `master` branch commit is must,
> I can do that.

I applied you patch. However, I rewrote your commit messages: they need
to refer to modified variables and functions. I also fixed dangling
parenthesis, and fixed a typo in a move from `mapc' + `lambda' to
`dolist'.

Thank you.

Regards,

-- 
Nicolas Goaziou