emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Michaël Cadilhac" <michael@cadilhac.name>
Cc: Keith David Bershatsky <esq@lawlist.com>, emacs-orgmode@gnu.org
Subject: Re: Completely hide the :PROPERTIES: drawer in org-mode.
Date: Thu, 14 Feb 2019 17:11:13 +0100	[thread overview]
Message-ID: <87y36iqrj2.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CADt3fpPVs1d2wqeA=KoTwkabaV5hdJJSXKv9D3=ycxd26=fBoA@mail.gmail.com> ("Michaël Cadilhac"'s message of "Thu, 14 Feb 2019 14:16:20 +0000")

Hello,

Michaël Cadilhac <michael@cadilhac.name> writes:

> I agree; following your advice, I took the simpler path of customizing
> org-special-keyword.  By changing its height, I got a small glitch;
> consider:
>   https://michael.cadilhac.name/public/org-props-small-1.png
> The lines with ":PROPERTIES:" did not change height; this is simply
> due to the line-feed having the default face.  With:
>
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -5934,7 +5934,7 @@ by a #."
>    "Fontify drawers."
>    (when (re-search-forward org-drawer-regexp limit t)
>      (add-text-properties
> -     (match-beginning 0) (match-end 0)
> +     (match-beginning 0) (+ 1 (match-end 0))

I suggest replacing (match-beginning 0) and (match-end 0) by,
respectively (line-beginning-position) and (line-beginning-position 2)

(+ 1 (match-end 0)) could be greater than (point-max),
(line-beginning-position 2) cannot.

>       '(font-lock-fontified t face org-special-keyword))
>      (org-remove-flyspell-overlays-in (match-beginning 0) (match-end 0))
>      t))
>
> I get the desired outcome:
>   https://michael.cadilhac.name/public/org-props-small-2.png
>
> (this is also where org-special-keyword should be replaced with org-drawer.)
>
> Any thoughts?

Would you want to provide a patch including the replacement of
`org-special-keyword' with `org-drawer'?

Thank you!

Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2019-02-14 16:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-07 16:21 Completely hide the :PROPERTIES: drawer in org-mode Keith David Bershatsky
2019-02-12  8:37 ` Nicolas Goaziou
2019-02-12 20:17   ` Michaël Cadilhac
2019-02-13 14:32     ` Nicolas Goaziou
2019-02-13 15:11       ` Michaël Cadilhac
2019-02-13 15:55         ` Nicolas Goaziou
2019-02-14 14:16           ` Michaël Cadilhac
2019-02-14 16:11             ` Nicolas Goaziou [this message]
2019-02-14 16:21               ` Michaël Cadilhac
2019-02-14 23:15                 ` Nicolas Goaziou
2019-08-28 22:38                   ` Michaël Cadilhac
2019-09-05 16:54                     ` Nicolas Goaziou
2019-02-13 18:44       ` Marco Wahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y36iqrj2.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=esq@lawlist.com \
    --cc=michael@cadilhac.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).