emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Ruby tests
@ 2019-05-12 13:20 Achim Gratz
  2019-05-12 22:56 ` Nicolas Goaziou
  0 siblings, 1 reply; 4+ messages in thread
From: Achim Gratz @ 2019-05-12 13:20 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 67 bytes --]


Ruby tests have been failing for quite some time, here's my fix.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-test-ob-ruby.el-fix-tests.patch --]
[-- Type: text/x-patch, Size: 2564 bytes --]

From 2f1bbaab939f6b6ceceb72862470e0576a8e2cba Mon Sep 17 00:00:00 2001
From: Achim Gratz <Stromeko@Stromeko.DE>
Date: Sun, 12 May 2019 13:14:04 +0200
Subject: [PATCH 1/1] test-ob-ruby.el: fix tests

* testing/lisp/test-ob-ruby.el: Output no longer contains a trailing
  newline, remove from the template to compare against.  Session must
  be named for the tests to actually work, also add some extra code to
  ascertain that the code after the output statement has actually run
  in the session.
---
 testing/lisp/test-ob-ruby.el | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/testing/lisp/test-ob-ruby.el b/testing/lisp/test-ob-ruby.el
index f42987b639..4d676fe19a 100644
--- a/testing/lisp/test-ob-ruby.el
+++ b/testing/lisp/test-ob-ruby.el
@@ -22,57 +22,58 @@
   (signal 'missing-test-dependency "Support for Ruby code blocks"))
 
 (ert-deftest test-ob-ruby/session-output-1 ()
-    (should (equal (org-test-with-temp-text "#+begin_src ruby :session :results output
+    (should (equal (org-test-with-temp-text "#+begin_src ruby :session org-test-ruby :results output
 s = \"1\"
 s = \"2\"
 s = \"3\"
 puts s
+s = \"4\"
 #+end_src"
   (org-babel-execute-maybe)
   (substring-no-properties
    (buffer-string)))
-		   "#+begin_src ruby :session :results output
+		   "#+begin_src ruby :session org-test-ruby :results output
 s = \"1\"
 s = \"2\"
 s = \"3\"
 puts s
+s = \"4\"
 #+end_src
 
 #+RESULTS:
 : 3
-
 ")))
 (ert-deftest test-ob-ruby/session-output-2 ()
-    (should (equal (org-test-with-temp-text "#+begin_src ruby :session :results output
-s = \"5\"
+    (should (equal (org-test-with-temp-text "#+begin_src ruby :session org-test-ruby :results output
 puts s
+s = \"5\"
 #+end_src"
   (org-babel-execute-maybe)
   (substring-no-properties
    (buffer-string)))
-		   "#+begin_src ruby :session :results output
-s = \"5\"
+		   "#+begin_src ruby :session org-test-ruby :results output
 puts s
+s = \"5\"
 #+end_src
 
 #+RESULTS:
-: 5
-
+: 4
 ")))
 (ert-deftest test-ob-ruby/session-output-3 ()
-    (should (equal (org-test-with-temp-text "#+begin_src ruby :session :results output
+    (should (equal (org-test-with-temp-text "#+begin_src ruby :session org-test-ruby :results output
 puts s
+s = \"6\"
 #+end_src"
   (org-babel-execute-maybe)
   (substring-no-properties
    (buffer-string)))
-		   "#+begin_src ruby :session :results output
+		   "#+begin_src ruby :session org-test-ruby :results output
 puts s
+s = \"6\"
 #+end_src
 
 #+RESULTS:
 : 5
-
 ")))
 
 (provide 'test-ob-ruby)
-- 
2.21.0


[-- Attachment #3: Type: text/plain, Size: 192 bytes --]



Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptation for Waldorf rackAttack V1.04R1:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Ruby tests
  2019-05-12 13:20 [PATCH] Ruby tests Achim Gratz
@ 2019-05-12 22:56 ` Nicolas Goaziou
  2019-05-15 19:15   ` Achim Gratz
  0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2019-05-12 22:56 UTC (permalink / raw)
  To: Achim Gratz; +Cc: emacs-orgmode

Hello,

Achim Gratz <Stromeko@nexgo.de> writes:

> Ruby tests have been failing for quite some time, here's my fix.

Feel free to push these changes if they fix tests for you.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Ruby tests
  2019-05-12 22:56 ` Nicolas Goaziou
@ 2019-05-15 19:15   ` Achim Gratz
  2019-05-16  9:00     ` Nicolas Goaziou
  0 siblings, 1 reply; 4+ messages in thread
From: Achim Gratz @ 2019-05-15 19:15 UTC (permalink / raw)
  To: emacs-orgmode

Nicolas Goaziou writes:
>> Ruby tests have been failing for quite some time, here's my fix.
>
> Feel free to push these changes if they fix tests for you.

I no longer have the commit bit since the server software was changed.
If it still requires an account on the server then I don't intend to
create one, either.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Ruby tests
  2019-05-15 19:15   ` Achim Gratz
@ 2019-05-16  9:00     ` Nicolas Goaziou
  0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2019-05-16  9:00 UTC (permalink / raw)
  To: Achim Gratz; +Cc: emacs-orgmode

Hello,

Achim Gratz <Stromeko@nexgo.de> writes:

> I no longer have the commit bit since the server software was changed.
> If it still requires an account on the server then I don't intend to
> create one, either.

I don't remember. You may want to ask Bastien about it. The project
certainly needs more contributors with commit rights.

I pushed your fixes. Thank you.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-05-16  9:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-12 13:20 [PATCH] Ruby tests Achim Gratz
2019-05-12 22:56 ` Nicolas Goaziou
2019-05-15 19:15   ` Achim Gratz
2019-05-16  9:00     ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).