From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [RFC PATCH] specify a time, not number of minutes to keep, with
 org-resolve-clock
Date: Sat, 01 Feb 2020 11:22:15 +0100
Message-ID: <87y2tmd2ug.fsf@nicolasgoaziou.fr>
References: <CAKqbAeEPFi8jDEP0D7OCQxUdpc0pRdQ0PEuwrbWB1T1S8Lv5sg@mail.gmail.com>
 <87sgk4o2j2.fsf@nicolasgoaziou.fr> <87imkuwhs4.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:47027)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <mail@nicolasgoaziou.fr>) id 1ixpv5-00011g-KH
 for emacs-orgmode@gnu.org; Sat, 01 Feb 2020 05:22:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mail@nicolasgoaziou.fr>) id 1ixpv4-00082u-4t
 for emacs-orgmode@gnu.org; Sat, 01 Feb 2020 05:22:31 -0500
In-Reply-To: <87imkuwhs4.fsf@gnu.org> (Bastien's message of "Wed, 29 Jan 2020
 13:47:55 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
To: Bastien <bzg@gnu.org>
Cc: Dan Drake <dan.drake@gmail.com>, emacs-orgmode@gnu.org

Hello,

Bastien <bzg@gnu.org> writes:

> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>
>> TINYCHANGE is only about the number of non-trivial lines of code in
>> your patch (15 or so).
>
> I would not say "non-trivial lines" of code.
>
> The change should be less *than 15 lines or so* to be accepted.
>
> I may be wrong, but this is how I read this:
> https://www.gnu.org/prep/maintain/maintain.html

I disagree. As stated in this page, only lines of code significant
copyright-wise count.

Commenting a line of code, changing indentation (e.g., when you wrap
a `let') do not count. You cannot copyright an indentation change. Nor
a symbol renaming (this example is even given in the page above). Also,
applying the same change multiple times may count /at most/ once.

So, I stand on my ground: there is a "non-trivial" part to take into
consideration when counting locs.

I would go even further: when you transform a string regexp into a rx
regexp, there is no line to count, because there is no new idea to
copyright in the first place. This is a trivial change.

Anyway, I think arguing here is just wasting our time.

Regards,

-- 
Nicolas Goaziou