From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id gCVYNA6k/l4eUQAA0tVLHw (envelope-from ) for ; Fri, 03 Jul 2020 03:20:46 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id yGsPMA6k/l4lSAAAbx9fmQ (envelope-from ) for ; Fri, 03 Jul 2020 03:20:46 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 39B88940221 for ; Fri, 3 Jul 2020 03:20:46 +0000 (UTC) Received: from localhost ([::1]:52462 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jrCFn-0003BB-70 for larch@yhetil.org; Thu, 02 Jul 2020 23:20:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42354) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jrCF7-00036g-IX for emacs-orgmode@gnu.org; Thu, 02 Jul 2020 23:20:01 -0400 Received: from [183.249.139.74] (port=11122 helo=localhost) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jrCF4-0006Bb-Lf for emacs-orgmode@gnu.org; Thu, 02 Jul 2020 23:20:01 -0400 Received: by localhost (Postfix, from userid 1000) id 4DE5624141A; Fri, 3 Jul 2020 11:10:54 +0800 (CST) References: <874kr6402z.fsf@gmail.com> User-agent: mu4e 1.4; emacs 28.0.50 From: stardiviner To: agzam.ibragimov@gmail.com Subject: Re: patch: ob-clojure improvements In-reply-to: Date: Fri, 03 Jul 2020 11:10:54 +0800 Message-ID: <87y2o11ef5.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Host-Lookup-Failed: Reverse DNS lookup failed for 183.249.139.74 (deferred) Received-SPF: softfail client-ip=183.249.139.74; envelope-from=numbchild@gmail.com; helo=localhost X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/02 23:10:55 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: 63 X-Spam_score: 6.3 X-Spam_bar: ++++++ X-Spam_report: (6.3 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FROM=0.001, FSL_HELO_NON_FQDN_1=0.001, HELO_LOCALHOST=3.828, NML_ADSP_CUSTOM_MED=0.9, RDNS_NONE=0.793, SPF_SOFTFAIL=0.665, SPOOFED_FREEMAIL_NO_RDNS=1, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: reject X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: numbchild@gmail.com Cc: Bastien Guerry , org-mode-email Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.91 X-TUID: ryMqa5vKDlfi agzam.ibragimov@gmail.com writes: > There seems to be a bit of lack of interest for these things. But I'm sure > some people (myself included) would love to see these kinds of > improvements. Yes, I rarely saw Clojurians in this mailing list. > As I said before, I have never participated in contributing > to Org source, some guidance would be appreciated. Org Mode has contribution guide here http://orgmode.org/worg/org-contribute.html#patches > Should I keep building it and posting patches? Should I try to go > incrementally, one small change at a time, or should I just get everything > working first? If it turns out to be a bigger work, should I ask for > permission to work in a branch and get access to pushing things to it? Maybe > things just move slowly, because obviously you can't force maintainers to drop > everything and concentrate effort to get your things in. Maybe I just have to > be a little bit more patient? I think a complete work contains many patches should be better, Also write testing if necessary. I remember ob-clojure.el code are mostly reviewed by Bastien Guerry. I included him in Cc: in this email. > On Sat, Jun 20, 2020 at 1:23 AM stardiviner wrote: > >> >> Glad to see your patch, really useful in some cases. Thanks. >> >> Ag Ibragimov writes: >> >> > Hi everyone, here's my attempt to add clojure CLI and babashka support >> for ob-clojure.el >> > >> > - Adds a header parameter to override org-babel-clojure-backend >> > - Adds :args param (right now only used for clojure-cli) >> > >> > I have tested it with these minimal cases: >> > >> > #+begin_src clojure :backend clj-cli :args "-Sdeps '{:deps {inflections >> {:mvn/version \"0.13.2\"}}}'" >> > (use 'inflections.core) >> > (plural "word") >> > #+end_src >> > >> > #+begin_src clojure :backend babashka :results output >> > (range 10) >> > #+end_src >> > >> > Please let me know what you think. Any advice is appreciated, since I >> have never contributed before. Thank you. >> >> >> -- >> [ stardiviner ] >> I try to make every word tell the meaning that I want to express. >> >> Blog: https://stardiviner.github.io/ >> IRC(freenode): stardiviner, Matrix: stardiviner >> GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 >> -- [ stardiviner ] I try to make every word tell the meaning that I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3