emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Kyle Meyer <kyle@kyleam.com>
Cc: emacs-orgmode@gnu.org, Stefan Kangas <stefan@marxist.se>
Subject: Re: [PATCH] New function org-agenda-filter-set
Date: Sat, 05 Sep 2020 09:45:40 +0200	[thread overview]
Message-ID: <87y2lo7jkr.fsf@gnu.org> (raw)
In-Reply-To: <874krqw4du.fsf@kyleam.com> (Kyle Meyer's message of "Fri, 05 Jun 2020 03:58:05 +0000")

Hi Kyle and Stefan,

Kyle Meyer <kyle@kyleam.com> writes:

> Bastien writes:
>
>> I've seen problems with this new function when completing in agendas:
>> hitting '/' does not see what tags are available for completion in the
>> current buffer.
>>
>> I'm reverting e9b1b8fde5 from master for now. If you see what's wrong,
>> please resubmit a patch.
>
> Stepping through both versions, it looks like the crucial thing is that
> org-agenda-get-represented-tags needs to be called _before_ the
> completion function.  If it's not, org-agenda-filter-completion-function
> calls -get-represented-tags with an unset cache, and it returns nil
> because the (derived-mode-p 'org-agenda-mode) condition is nil.
>
> The same goes for org-agenda-get-represented-categories.

Thanks for analysing this -- Stefan, if you still feel like going
through this refactoring, this would be a welcome improvement for
after 9.4 (coming soon).

-- 
 Bastien


      reply	other threads:[~2020-09-05  7:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-21  6:23 Stefan Kangas
2020-05-23  5:02 ` Kyle Meyer
2020-05-23  5:16   ` Stefan Kangas
2020-05-23  9:07 ` Bastien
2020-06-01 12:50 ` Bastien
2020-06-05  3:58   ` Kyle Meyer
2020-09-05  7:45     ` Bastien [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2lo7jkr.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=kyle@kyleam.com \
    --cc=stefan@marxist.se \
    --subject='Re: [PATCH] New function org-agenda-filter-set' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).