emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Tim Cross <theophilusx@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [SOLVED] (kinda) Calendar vs. org-agenda exit
Date: Fri, 25 Jun 2021 06:54:25 +1000	[thread overview]
Message-ID: <87y2azkmjt.fsf@gmail.com> (raw)
In-Reply-To: <87sg175t63.fsf@gmx.net>


Stephen Berman <stephen.berman@gmx.net> writes:

> On Thu, 24 Jun 2021 14:09:46 +0200 tomas@tuxteam.de wrote:
>
>> On Thu, Jun 24, 2021 at 12:13:40PM +0200, Stephen Berman wrote:
>>> On Wed, 23 Jun 2021 18:16:52 +0200 tomas@tuxteam.de wrote:
>>>
>>> > On Wed, Jun 23, 2021 at 05:28:36PM +0200, tomas@tuxteam.de wrote:
>>> >
>>> > [calendar insert-diary-entry doing funny things]
>>> >
>>> > OK, I solved it by setting `org-calendar-insert-diary-entry-key' to
>>> > [106], which is a ?j. It was set to ?i, which hijacked calendar's
>>> > original key map.
>>> >
>>> > Now I still don't know whether it's intended that Org hijacks that
>>> > key in calendar, whether I did something stupid, but at least I have
>>> > my toys back. Just remember to not push ?j.
>>> >
>>> > Anyway, you set me on the right track, so thanks for that!
>>>
>>> See also bug#48199 (also CC'd at
>>> https://lists.gnu.org/archive/html/emacs-orgmode/2021-05/msg00582.html).
>>> I continue to use the patch I posted there and have had no problems with
>>> it (but I don't use org-mode much).
>>
>> Oh, I see, thanks. For me, it's a bit confusing that this bug receives
>> so little attention. Hijacking other modes's keymaps isn't... friendly,
>> after all. I can't imagine that it is happening by intention.
>
> Yeah, the next time Org is merged to the Emacs master branch, forcing me
> to first stash and then reapply my patch locally, I'll ask if anyone
> objects to the patch being committed to master.  Maybe that will get
> someone's attention (and if not, I may just go ahead and commit it -- if
> it then still gets no one's attention, it must be ok ;-).
>

My view is that if org-mode is stealing the calendar bindings by default
i.e. user has not enabled some specific option/configuration to do this,
then this is a bug. Org should not interfere with the key bindings of
any mode unless asked to. Some people still like to use traditional
Emacs diary rather than org agenda for scheduling meetings/appointments,
but like to use (load) org for other things (like document authoring and
TODO lists). Org should only override the calendar bindings if
requested.

If your patch fixes this, I vote to apply it to master.


-- 
Tim Cross


  parent reply	other threads:[~2021-06-24 20:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22 10:39 org-edit-src-exit randomizes / mixes up code in source-buffer on exit mcg
2021-06-22 13:33 ` Sébastien Miquel
2021-06-22 14:57   ` mcg
2021-06-23  9:15 ` Calendar vs. org-agenda exit tomas
2021-06-23 15:16   ` Marco Wahl
2021-06-23 15:28     ` tomas
2021-06-23 16:16       ` [SOLVED] (kinda) " tomas
2021-06-24 10:13         ` Stephen Berman
2021-06-24 12:09           ` tomas
2021-06-24 12:44             ` Stephen Berman
2021-06-24 15:04               ` Nicolas Goaziou
2021-06-24 17:28                 ` tomas
2021-06-24 20:54               ` Tim Cross [this message]
2021-06-24 21:07                 ` tomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2azkmjt.fsf@gmail.com \
    --to=theophilusx@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).