emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: guillaume@gbuisson.com
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix ob-plantuml over TRAMP
Date: Thu, 25 Nov 2021 20:40:35 +0800	[thread overview]
Message-ID: <87y25c1k8s.fsf@localhost> (raw)
In-Reply-To: <F23A8F0C-60D9-4977-BD14-985CE25C2E17@gbuisson.com>

guillaume@gbuisson.com writes:

> It seems to me that there is a redundant check which uses `file-exists-p` even if using TRAMP, the plantuml jar is located on the remote server, so 
> it fails with an error even though the command to actually render the diagrams works fine.

I disagree that the check is redundant. It is still a good idea to check
if plantuml jar exists on server itself. Another question is how to make
`file-exists-p' work with TRAMP.

> The patch I propose involves keeping this check but moving it so it only generates a message instead of failing the whole generation process,
> doing so allows to restore the functionality and I can finally generate my sequence diagrams over TRAMP.

Your patch will break legitimate check for people running plantuml
locally. A better way would be checking default-directory and if we are
in a remote server, using appropriate check working over TRAMP.

Best,
Ihor


  reply	other threads:[~2021-11-25 12:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 17:29 guillaume
2021-11-25 12:40 ` Ihor Radchenko [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-11-24 16:11 Guillaume Buisson (gbuisson)
2021-12-02  9:43 ` Timothy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y25c1k8s.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=guillaume@gbuisson.com \
    --subject='Re: [PATCH] Fix ob-plantuml over TRAMP' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).