From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oKnlG0bQtGGPwgAAgWs5BA (envelope-from ) for ; Sat, 11 Dec 2021 17:22:30 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id qFOcF0bQtGF8JgAA1q6Kng (envelope-from ) for ; Sat, 11 Dec 2021 16:22:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F12D0178F9 for ; Sat, 11 Dec 2021 17:22:29 +0100 (CET) Received: from localhost ([::1]:53404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mw58n-000085-5w for larch@yhetil.org; Sat, 11 Dec 2021 11:22:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mw58N-00005u-BH for emacs-orgmode@gnu.org; Sat, 11 Dec 2021 11:22:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:38373) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mw58N-0004PD-2g for emacs-orgmode@gnu.org; Sat, 11 Dec 2021 11:22:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mw58M-00013P-GN for emacs-orgmode@gnu.org; Sat, 11 Dec 2021 11:22:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#51365: 29.0.50; org-mode: modification-time error with git controled file Resent-From: Kyle Meyer Original-Sender: "Debbugs-submit" Resent-CC: emacs-orgmode@gnu.org Resent-Date: Sat, 11 Dec 2021 16:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51365 X-GNU-PR-Package: org-mode X-GNU-PR-Keywords: To: TAKAHASHI Yoshio Received: via spool by 51365-submit@debbugs.gnu.org id=B51365.16392396703980 (code B ref 51365); Sat, 11 Dec 2021 16:22:02 +0000 Received: (at 51365) by debbugs.gnu.org; 11 Dec 2021 16:21:10 +0000 Received: from localhost ([127.0.0.1]:49917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mw57V-000126-Jc for submit@debbugs.gnu.org; Sat, 11 Dec 2021 11:21:09 -0500 Received: from out0.migadu.com ([94.23.1.103]:51350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mw57O-00011F-Hb; Sat, 11 Dec 2021 11:21:08 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1639239660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QEhhbvWNxCoCl3fv/+m3hNQt9nQOcvu7S4SDRKQyZxw=; b=zF1mvl6fc9nxtEBnpmL/6GLdJgpCdf2AGmqQa9ha7kgNSfcsqBn31YkrCt5dfslQtXjQNb 6TkPTZu5pQyTON4ZIYbuFPO9t/2buHJUVoue/6KNykzIoxVJ7Gr7nuUHfntzwYNk7UiT/0 tnc96Olc+YJmZeWcPhqaWvsMMpMxgSKWNXE0vUdreXG/oz+EL+Jo4t3hNoplVnD4HB8vN+ kr0GGeKc+c1oio99qD62949RO5DnmK7wA8H3zmTfu9DN71r0NAQ+ONJM6O3PcYkRGFaLvB ITPQgpaJyKstbLQwX248rBHbNnaphnPEkZMgQeGo9p3eRzkn+ZY5kWwZHHVBnA== From: Kyle Meyer In-Reply-To: <878ryjb1y8.fsf@yfb02119.nifty.com> References: <878ryjb1y8.fsf@yfb02119.nifty.com> Date: Sat, 11 Dec 2021 11:20:58 -0500 Message-ID: <87y24rdset.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: emacs-orgmode@gnu.org List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 51365@debbugs.gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639239750; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=QEhhbvWNxCoCl3fv/+m3hNQt9nQOcvu7S4SDRKQyZxw=; b=ieFQHivqg/l6a5r1iGavpiZv2ZQ0uTzpZdN0ib1UjWZHBWoIUfgczcgfp0Kuco/YwvcT/w 2obi2zlinvXGRQVe6F+G4SG2ipNg+K2COHGrm/jkIS/NJPkUE6ZkWKPZrLdLV1Acx889gA ToIEJbDCDhrKDkC122UUydDzbnpOgY5yaQmRVra5LSo0JjkJ8ZsyZmiJZn/Yq0J/MbRC2i 7/wTEgWgkqbrZFXgrEWmqpkwGNK+XeYLuZvDGec86POAnOP1Ev3o78dldPift3TAR7+lVl oNKSxtACcGjN00ZcdsMJeYkYAzhbbl6X1NyBwDu4FTXzSDNQgtpHlw/M00oo4w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639239750; a=rsa-sha256; cv=none; b=PKb4bOos266wbWvbLW87BUfdE1i6L+xUwq92HoGC9h7lSZ5bNLhneuaN6wiAvZdmXGyQQa enIYLzibVpQmmxvCMl9MBNtN9dfEJTsBYrDgba92VrVdrP4xWAtCoZYzSZ24pYXLGMVXY1 8dUA9PYcEs7IUqBW8nfy1I+EjH+rJbT0WhgNAgF6yBwhyJYzgGaemt7oySTYoSBwL9Ze/J LY0PU7cNpqkxE9e0YVrdtoDNwDuSScOVNbq/mbCVMYI41i2mV426D5gUh52rnroC5gbrgi WERx8fzenfSKai0gdxK3cz0A4TODC0vTcdc0RdxFMiaHVQWm+7XINPFdjbtV2Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kyleam.com header.s=key1 header.b=zF1mvl6f; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.06 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kyleam.com header.s=key1 header.b=zF1mvl6f; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: F12D0178F9 X-Spam-Score: -2.06 X-Migadu-Scanner: scn1.migadu.com X-TUID: nqwDMIA5hzj/ close 51365 28.1 quit TAKAHASHI Yoshio writes: > Hi, > > With git controled file, > {{{modification-time(%Y-%02m-%02dT%02H:%02M:%02S+09:00, 1)}}} > causes "Wrong type argument: stringp, " error. > > `org-macro--vc-modified-time' in org-macro.el should pass list of FILE > to `vc-call', because `vc-git-print-log' expects list of file as its 1st > argument. Thanks for the report and fix. This failure is new with Emacs 28, specifically 3572613550f (Fix vc-git-state for filenames with wildcards, 2021-08-15). Before that, passing a string instead of a list worked okay because vc-git-print-log just passed its FILES argument untouched to vc-git-command's FILE-OR-LIST. > diff --git a/lisp/org/org-macro.el b/lisp/org/org-macro.el > index b8d3373418..9e70844963 100644 > --- a/lisp/org/org-macro.el > +++ b/lisp/org/org-macro.el > @@ -368,7 +368,7 @@ org-macro--vc-modified-time > date) > (unwind-protect > (progn > - (vc-call print-log file buf nil nil 1) > + (vc-call print-log (list file) buf nil nil 1) > (with-current-buffer buf > (vc-exec-after > (lambda () Looks good to me. I confirmed the bug and fix only with vc-git, although the change looks appropriate for the other backends too: $ git grep -E '\(defun vc-.+-print-log' lisp/vc/vc-bzr.el:(defun vc-bzr-print-log (files buffer &optional shortlog start-revision limit) lisp/vc/vc-cvs.el:(defun vc-cvs-print-log (files buffer &optional _shortlog _start-revision limit) lisp/vc/vc-dav.el:(defun vc-dav-print-log (_url) lisp/vc/vc-git.el:(defun vc-git-print-log (files buffer &optional shortlog start-revision limit) lisp/vc/vc-hg.el:(defun vc-hg-print-log (files buffer &optional shortlog start-revision limit) lisp/vc/vc-mtn.el:(defun vc-mtn-print-log (files buffer &optional _shortlog start-revision limit) lisp/vc/vc-rcs.el:(defun vc-rcs-print-log-cleanup () lisp/vc/vc-rcs.el:(defun vc-rcs-print-log (files buffer &optional _shortlog lisp/vc/vc-sccs.el:(defun vc-sccs-print-log (files buffer &optional _shortlog _start-revision-ignored limit) lisp/vc/vc-src.el:(defun vc-src-print-log (files buffer &optional shortlog _start-revision limit) lisp/vc/vc-svn.el:(defun vc-svn-print-log (files buffer &optional _shortlog start-revision limit) So, I've added a commit message to above patch and applied it in your name on Org's bugfix branch (888689f2b).