From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: post+orgmodeml@guelker.eu,
Emmanuel Charpentier <emm.charpentier@free.fr>,
emacs-org list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] c-csl : accept relative CSL filenames
Date: Fri, 18 Feb 2022 19:16:49 +0100 [thread overview]
Message-ID: <87y2283ur2.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAFyQvY2SZ3jMWo2uwVq0bzTkZGog8eyDSEwhdBZVc8ui9K54vQ@mail.gmail.com> (Kaushal Modi's message of "Fri, 18 Feb 2022 09:51:32 -0500")
Hello,
Kaushal Modi <kaushal.modi@gmail.com> writes:
> Can this commit[1] be merged into the main branch.
It is already in the main branch, AFAIU. I assume you mean it should be
back-ported to bugfix branch. If that's the case, I don't know. This is
a new feature, and not a critical one: there are workarounds, as you
found out.
This should be available when Org 9.6 is released. I don't know when
that will happen.
> I believe the behavior I see with this commit on main branch is kind
> of obvious and it should prevent this surprise failure for other users
> too.
It's obvious, but, as a new feature, it was pushed to main instead of
bugfix. Note that the error message is explicit anyway.
I'm not strictly opposed to back-porting it to bugfix, but is there
a compelling reason to break our workflow in this case?
> This works for both main and bugfix, but while doing this, I realized
> that even string values are not considered safe for this variable.
>
> Looking through git revisions, I found
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=41e67cff0d3bf27ffb57f9a230598b0385341517.
n>
> Earlier `:safe t' was added for `org-cite-csl-styles-dir'. Instead can
> we have `:safe #'string-or-null-p' as suggested by Glenn Morris in
> that commit?
I don't think Glenn Morris suggests using #'string-or-null-p, which
would contradict his statement. He is pointing out that ":safe
#'string-or-null-p" is better than ":safe t", even though but allowing
arbitrary locations (strings in this case) is not safe anyway.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2022-02-18 18:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 17:56 Emmanuel Charpentier
2021-11-19 12:54 ` Nicolas Goaziou
2021-11-19 18:10 ` M. ‘quintus’ Gülker
2021-12-10 9:20 ` Nicolas Goaziou
2022-02-18 14:51 ` Kaushal Modi
2022-02-18 18:16 ` Nicolas Goaziou [this message]
2022-02-18 19:17 ` Kaushal Modi
-- strict thread matches above, loose matches on Subject: below --
2021-10-19 18:24 Emmanuel Charpentier
2021-11-03 16:19 ` Nicolas Goaziou
2021-11-04 16:25 ` Emmanuel Charpentier
2021-11-04 22:16 ` Nicolas Goaziou
2021-11-04 22:36 ` Bruce D'Arcus
2021-11-05 12:18 ` Eric S Fraga
2021-11-05 9:38 ` M. ‘quintus’ Gülker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2283ur2.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=emm.charpentier@free.fr \
--cc=kaushal.modi@gmail.com \
--cc=post+orgmodeml@guelker.eu \
--subject='Re: [PATCH] c-csl : accept relative CSL filenames' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).