From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id IPf3In+SkWKtfAEAbAwnHQ (envelope-from ) for ; Sat, 28 May 2022 05:09:51 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id ODDZIn+SkWKKAwAAauVa8A (envelope-from ) for ; Sat, 28 May 2022 05:09:51 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 320023FB16 for ; Sat, 28 May 2022 05:09:51 +0200 (CEST) Received: from localhost ([::1]:44286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1numpq-0003RJ-E2 for larch@yhetil.org; Fri, 27 May 2022 23:09:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1numov-0003RB-Ky for emacs-orgmode@gnu.org; Fri, 27 May 2022 23:08:53 -0400 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]:39465) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1numou-0000NB-1O for emacs-orgmode@gnu.org; Fri, 27 May 2022 23:08:53 -0400 Received: by mail-pf1-x429.google.com with SMTP id y1so5847238pfr.6 for ; Fri, 27 May 2022 20:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=sRFlBmjBCzz5WqQzvpnLzCoXwOyqjctm2tJgEiPHHEA=; b=kaC/muwr1AwR2mCTX4zxBtNTHQtKGQh6tC35Hrt77iK6N9I+zFywlC0hIl0AZ4YOfl +aQdQg//0pbZqMqWmQcAsHrBxGED1+YShVbZS0n/m9RTzbSQdTzz84Ip+fahgyly9c0V dxo/T6Q7Bifph3qmk9Mrck3uGUkHq40EyrNoiAGZKioGl4a6ENFJxDVfKTHy0aothp/p VyRfjOM4MI+AvJuHxnRt0YLtSXqinimeL2xinXoMZb5PdOAEAfVFLDKK0SewR7MVdZt5 ndRQWqDuZJoKz5Sa4u3zK9g+2qEgKMOLtKO1cbqoT8IjoODSlqj/aaaweLOoaS5b7MXB t8HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=sRFlBmjBCzz5WqQzvpnLzCoXwOyqjctm2tJgEiPHHEA=; b=YbO5nhw4EaTHL8rumZLa9Zs4WTwRkm+dpPG/9dA4mJNVT8C/JGO04XuzlTIzyGI0/c /QCfWPgO33amifVnc+p18+xP2zWAdMCQUIG58ayFU8hTvLRGzAWppYXRFty6vs0Wr+UW zk8veumO4vXtjIHUHqp7a8XU5r1/3nQC+ytQbsuaVDrEQ4rFmverISMsISXttKKmQR2R +3A87ulV7AE1KLElMjzvn8rBtEXEJFgc7grsZTdMpvToUzqYiL7DXZQqW/6J4Cl8OXkE R6avDTUzk+2Nq26mIFFItF+Q9putjifyBjprghP86bhDLidAWmN8zsPQgtF4a1L3mtBc F2jw== X-Gm-Message-State: AOAM532QtiixKwznXCHxTZRKmflF7/f6kS6elqMJ28Ed/3nL1sXNj4yk 7IsFON+Ho3YLd5qOrkV60BA= X-Google-Smtp-Source: ABdhPJzHbBjXZXVmuYnbXaswypytNuBOvP9aqTOsfU6TZ6oAZN/3tIBlFN5ErMkpA1624Zak0HVxRg== X-Received: by 2002:a63:535c:0:b0:3db:69da:1ef7 with SMTP id t28-20020a63535c000000b003db69da1ef7mr40342982pgl.239.1653707330680; Fri, 27 May 2022 20:08:50 -0700 (PDT) Received: from localhost ([64.32.23.62]) by smtp.gmail.com with ESMTPSA id z6-20020a170903018600b0015e8d4eb25bsm4456310plg.165.2022.05.27.20.08.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 May 2022 20:08:50 -0700 (PDT) From: Ihor Radchenko To: Tom Gillespie Cc: emacs-orgmode Subject: Re: [BUG] 67275f4 broke evil-search Re: [PATCH 10/35] Implement link folding In-Reply-To: References: <87y2cvloay.fsf@gnu.org> <149145640c25d2ae191ab87c7056e372f9904370.1643454546.git.yantar92@gmail.com> <87sfpphkfc.fsf@localhost> <877d66e613.fsf@localhost> Date: Sat, 28 May 2022 11:09:30 +0800 Message-ID: <87y1ymcpzp.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::429; envelope-from=yantar92@gmail.com; helo=mail-pf1-x429.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653707391; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=sRFlBmjBCzz5WqQzvpnLzCoXwOyqjctm2tJgEiPHHEA=; b=RiI2zJv92XcxcGf0abQlNAPxqwYkhLr1xfu5oEYhGIrTTtF7pvoBDe05evZalYlMJut4rQ 9++1CAm39zk0SujiMyWaGOt2a9E0b4RMuZ+jxezo9JjK6FAHDMslFHpHa8qFwjQhPBw+wd 66ah6YtSQGeeRUSAyeJSH5oAoQIuFOlV5boR/zMbKIbyOpfLxHpOfnlgjN8J1CHDiUoCV8 zI6FYo4QXZRSGMGXAD8h7YLAfgx9b58h/PDJyYDNHBVkswGcp9GYglLRQqjC9zCihoiw3J ZO0FnqI6ds1+EtlZPe7fGueoz84ehranj5VOLr1FwOZrUU7HR7VWPB6RfOB31g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653707391; a=rsa-sha256; cv=none; b=F8MDwxTvi9ZOUaT4/5Bgm3QNsni26fVWhBs/ALFVDjGZesG5lTzLeI1k8qB4JCdW80mnHl gw9U7/uZWsI7MffY2UVaBRyg2E7zmhVJ6ysF+i7PDltG5kLehR4z8pu8EQY9k5tYk0LPiF agr4ysw34D8FiI3abEc6sF8qApVXi68sXCEkpsJp9rWi7B/+jazIJyZJurbQl7eviy9OKW GJ0Rzdyx/cQ6EeNx4pIt9Bl0xT1daTvXSh327+DeMMeuLvrXVv/BRAcwgUY1hQNobRr9yG eRqBE76lFJwXWxxj2MZaV0NLMRlpmQjpwqF8d8w56syCryvozRY6z1HNHveosg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="kaC/muwr"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -7.84 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="kaC/muwr"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 320023FB16 X-Spam-Score: -7.84 X-Migadu-Scanner: scn0.migadu.com X-TUID: PrIvM6PaQVVf Tom Gillespie writes: >> Note that if evil were to comply with the canonical isearch >> implementation and respect isearch-mode-end-hook, there would be no >> issue. > > I think we might want to update the documentation to mention > issue with evil for now, and alert the evil devs about this change. > Then we can approach them about implementing support for > searching inside invisible regions marked via text properties > since that is essentially a new feature that is being added to > org for 9.6, though one that will be on by default. Feel free to open an issue in evil repo. I do not use evil, so I will not be able to test any fixes there. > The evil-search > module doesn't seem to support _any_ of the isearch hooks needed > but while looking into this I think I know generally where it might be > possible to add them. Not exactly. Evil does support `isearch-filter-predicate', but not `isearch-mode-end-hook' and `isearch-mode-hook'. Basically, Org needs evil to support settings listed in `org-fold-core--isearch-setup'. Best, Ihor