From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id EJJOMqHyImPiegAAbAwnHQ (envelope-from ) for ; Thu, 15 Sep 2022 11:38:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 2FyPMaHyImNU2AAAG6o9tA (envelope-from ) for ; Thu, 15 Sep 2022 11:38:41 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7091B2DE90 for ; Thu, 15 Sep 2022 11:38:41 +0200 (CEST) Received: from localhost ([::1]:43184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYlKS-0005u2-ID for larch@yhetil.org; Thu, 15 Sep 2022 05:38:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYkVt-0003h0-32 for emacs-orgmode@gnu.org; Thu, 15 Sep 2022 04:46:29 -0400 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]:45739) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYkVr-0000xW-2l for emacs-orgmode@gnu.org; Thu, 15 Sep 2022 04:46:24 -0400 Received: by mail-pg1-x535.google.com with SMTP id h188so16673511pgc.12 for ; Thu, 15 Sep 2022 01:46:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date; bh=gkCKnvxxoss5UZ6S6cZDUyoO95RS+FCtvEvRby3QsLc=; b=kfEOvkSWjIiIRD4q65BYq8DTOrMDY4jHwT55zXffBZufOv9CIsKFiWVLRXwG3mKCDW N9h8vGLqO9REmHP8+hsBxbnmRwmBjm29/4WZNKp4+F0Qsk/iBBj+rm+jKglr9W+osn+i 6nMi3zCnofHbag5QhVuXTSpUDNxvcaculApW5ns5ioYt492lzFH+HXDV1Cet9VHgDnqI hG3T5Tx7OGzkkm+1Fozc434uSxRojLHrWQLuq0G4k8Wq/wWdtjK0g0WYt4W0sxT0twNC sqOEbId+QYyJA/+H+QqqEZIC25jJNS8ievffZdUQMwPh3Ad17MIYcFrDTocjO+KiIOlq veYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=gkCKnvxxoss5UZ6S6cZDUyoO95RS+FCtvEvRby3QsLc=; b=oIAWxQn1SEeUv9QjSX6HOQB3ShwP9j83JGfaFdneh7ex2JuJ/99Sf053MBAPc8On9K RaiWd1Ap3haAisZnxgRli19aTvBJaIoF0hlvpgmqvZ9oz1y1sJM+xSynkPZhrEwceTdH up+LRTm46JxC4eIezAZMI2nXycWBK8K6mL5B9oFCgCx1p3RcT/OJne/fV3Qeknn2wER4 nwZJyASLB6+w2L9vTj7uthN+rR6H60ggUooKySz5lsE8e1olaxlceEbf2M4GnwZTJToe gnt4qhZ1eNGpJ3PQeEMlHX36Pc70WSWup0U4WKpbsvTF7hLIe2Zbdsl+xYpmH6+S4OiT gU3Q== X-Gm-Message-State: ACgBeo3ioi8u0ttqK0UwTNLoX6KY/sZTF/ExP6OFpxU9qD3swXPDuwzo ksqhHbCqtLvFARfcapr/I8I= X-Google-Smtp-Source: AA6agR64uvYjchzjIh+HqUsPZJ4LiF/P8yAhKFs5j8imTH0fwZ0Oiq3RXoY3wubs1wnrEQtaipgbWg== X-Received: by 2002:a63:4d5b:0:b0:42c:299e:eecc with SMTP id n27-20020a634d5b000000b0042c299eeeccmr34932825pgl.41.1663231580384; Thu, 15 Sep 2022 01:46:20 -0700 (PDT) Received: from localhost ([2409:8970:a81:48f7:8ec6:81ff:fe70:339d]) by smtp.gmail.com with ESMTPSA id y15-20020a17090264cf00b00176a47e5840sm12225434pli.298.2022.09.15.01.46.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Sep 2022 01:46:19 -0700 (PDT) From: Ihor Radchenko To: "Christopher M. Miles" Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH 4] New: auto display inline images under subtree when `org-cycle'. In-Reply-To: <6322b0a8.050a0220.59bb8.6923SMTPIN_ADDED_BROKEN@mx.google.com> References: <631d472b.c80a0220.2b4b2.bf86SMTPIN_ADDED_BROKEN@mx.google.com> <87h71ew0m0.fsf@localhost> <631e92ee.050a0220.f9c18.92f5SMTPIN_ADDED_BROKEN@mx.google.com> <87y1uovp9w.fsf@localhost> <631fe1c9.050a0220.3ab2b.3f52SMTPIN_ADDED_BROKEN@mx.google.com> <87bkrhwc42.fsf@localhost> <6322b0a8.050a0220.59bb8.6923SMTPIN_ADDED_BROKEN@mx.google.com> Date: Thu, 15 Sep 2022 16:47:14 +0800 Message-ID: <87y1uluir1.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::535; envelope-from=yantar92@gmail.com; helo=mail-pg1-x535.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663234721; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=gkCKnvxxoss5UZ6S6cZDUyoO95RS+FCtvEvRby3QsLc=; b=qRn4/NTEcQg2WPFwEjBFZDEd845Syr2Sx5QJDlaIHAAd1v8sDEKXIFvU2dEETTxuY6sA1d /PXHjyP7pqTrZEkQUUi5RkOhUm/1whBuTcvf7k57zqnhgV2pGE02hyF0pBin2EhW2z6rzw mHnJXQ7TLz9hH/3h6N8EFa9GAeDM31G9Rxu2q0cZ7X6MGgpbG19SZcN5xwUA0KsP7Bz/n9 waU16VS/2rFJalKg0k4sl6jItjl6e/I34SUef6Qkvi8d/pssbZLEn0V6A4c1FVTmgG3zn+ 4ana3KmVKIWZOdmpkZ0ppIXxg0xVoUfR++flVbtN0PnPAFZyiJmwe9b/TaCPeA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663234721; a=rsa-sha256; cv=none; b=n/DSCjizT0I7B1HUe5uRWYUEaFB1vITN/Kxu+OaatPopj2qc63U3UF1O/VFbbCUOALGmXH 6FBSASEm7FlkO24QBtednZrkSvaahyTdWpVMiSDMTcPVuW81IKYIlQGVFchiaK+Krx2NG4 MeVcJ5Is/EEbIjLqSA1TWXqR6PAs/T2EDZ6eZx1InrcxsAtf5fZll9s5nEEsN3teawtFcl EatVavKENhYV0CNpwfBS68iDBoXtKBcnT+LommO99OA6KEJKbXGT54ng8AwggyOsfl+tCj KKsaCtiraC2nJ6MP8I6d+Ed5aT93wfz5FVnHQryiOq3CUOLt8RGPK9jtIbHJUg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=kfEOvkSW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.33 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=kfEOvkSW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7091B2DE90 X-Spam-Score: -3.33 X-Migadu-Scanner: scn1.migadu.com X-TUID: SqDu/Behxe/T "Christopher M. Miles" writes: >> Also, this change should be documented in etc/NEWS and also in >> "12.7 Images" section of the manual. > > Done. (the manual, you mean org-manual.org right? I found too many > documents under doc/ folder, confused for a while....) I meant doc/org-manual.org Note doc/Documentation_Standards.org for the conventions we use in the manual. Your patch does not follow those conventions (double space between sentences). > P.S: I merged two commits into one for clear. Let's not do it. They are two distinct changes and I will have significant comments regarding subtree cycling. (I had plans to implement cycling at point for images, and we may as well take this chance to create some generic infrastructure for showing/hiding the inline images). For now, lets sort out the ORG-IMAGE-ACTUAL-WIDTH property and get it merges. Then, we can move ahead to the subtree cycling feature. > * lisp/org.el (org-display-inline-image--width): support subtree-level ^S > +If you want to override global variable ~org-image-actual-width~ of > +inline image display width, you can specify property > +"=ORG-IMAGE-ACTUAL-WIDTH=" in subtree level. It will only affect > +inline images under the specified subtree. Could you also add a paragraph describing what org-image-actual-width does? > +*** New default property =ORG-IMAGE-ACTUAL-WIDTH= for overriding global ~org-image-actual-width~ I think that people may be confused by "default property" here. Just say "new property". > +The subtree-level property "ORG-IMAGE-ACTUAL-WIDTH" can override the > +global variable ~org-image-actual-width~ settings for inline images > +width under current property specified subtree. It is not necessarily subtree-level. You can as well set it in document-wide property drawer. Just say "The new property ... overrides ...". -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92