From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WkhlAfLX5GMHewAAbAwnHQ (envelope-from ) for ; Thu, 09 Feb 2023 12:24:34 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id kL9uAPLX5GNSuAAAauVa8A (envelope-from ) for ; Thu, 09 Feb 2023 12:24:34 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B87B71A2A4 for ; Thu, 9 Feb 2023 12:24:33 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQ51m-0005UQ-4N; Thu, 09 Feb 2023 06:23:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQ51l-0005U3-2L for emacs-orgmode@gnu.org; Thu, 09 Feb 2023 06:23:45 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQ51i-0001Hb-VS for emacs-orgmode@gnu.org; Thu, 09 Feb 2023 06:23:44 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 012A6240409 for ; Thu, 9 Feb 2023 12:23:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1675941821; bh=CcGGDLhjgxgQPcOYnHocYAAFs0YlQ4njF/u3RErLw4E=; h=From:To:Cc:Subject:Date:From; b=NoO3lghPc343M+L7Yl+3EcOkx4BrZFAbMZXPoSSPrUjUrZj48mnVOlNmogB8Vrwsu LPOhkd3oZauqlzSY95fRvhIE9kKMuCbnQFngJA7Y3dBHzEeCv8q4asPIYNY/lvuDxC oibG3TiD6AcA3Wph3JlD4zrhlqnPqlOCdS6BFNoqbXjdifzHCLoqQtB6yuLu6ewxh3 NHx6oXLmjW3FtQr34yCO7FtGbd5rg1uqQUvN0HVOc4zk3446B0vTUw6qtAPCppfAmR 9lnYxByMLub30vYtiXyMjY8ESBTBkwMTjqtVEu6+fzw/NHrBbO82b5EbqW3wV4mOpy 4IQNZLbUboXlA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PCDyK5CwWz6tm4; Thu, 9 Feb 2023 12:23:37 +0100 (CET) From: Ihor Radchenko To: Matt Cc: emacs-orgmode Subject: Re: [PATCH] Async evaluation in ob-shell In-Reply-To: <1863472efe9.10fdd5ba4258906.5972264927968042941@excalamus.com> References: <186283d230a.129f5feb61660123.3289004102603503414@excalamus.com> <87v8kd8zzw.fsf@localhost> <1863472efe9.10fdd5ba4258906.5972264927968042941@excalamus.com> Date: Thu, 09 Feb 2023 11:24:13 +0000 Message-ID: <87y1p7axpe.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675941873; a=rsa-sha256; cv=none; b=WVd2+TV3I7ZQrbIRs7/yzKRE+3Xt09eD6sR59LTlpMZFSV61yNlXMnt6TklFshxJMDzA26 bAa2SKjbw9qjwtaMI31Z2RQc+T8ItrPoKpsd+aMcY/eLfY3BJOe5zWXxZeyr8KNGbd0+F2 yOP1WNaBj8Sl7aEVRUS3Uay9ufna2SjPk4UI8OOUpnREWoMs9OpaizdWhr03geambOWjzJ TxgtQhnBbfEcR1N0Rz32EN7ed79az1xmycnpcCTVHEdK+XZnh13ap8LYJpFIZ5gTnEiUJs SeT5Jo6ZD9lKTDzlnMJxxFzv0g+ZRbk9m69A6Oxves2SlyjZhFStDVXntgsrhQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=NoO3lghP; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675941873; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=MUD5CFltyGeAIuWvpjcXcEwzWufztS/AFY61ac1JO78=; b=R6cqMWBKfgNf3nuOJJ9D7tctr/YanH2v86LXw0SfXn4n7ucivhpghiRqIhnDD3bzIeaDMh 6HT8E/zPpgoC2J12ith8m7BOuvVaI4Yl74oQ5Y+TsEZJOGA/ZgUKL1zvjISw1PH2elc0FX ozHp6mNIzhWpv9eFiwsgC9/k3QviQTFOc/EQ/w+ITc4sg2KYCNh5REwiQiazBRjnsdV65X PJ4vEx6OpyMAaU0Z9ZF+f0O15hLtH3HBkAwMlZQP9TSVk6vbJ+NEFHeHpdsxOgs4cBdrCE AkRL5lUINeUfk8SULDg2YwCFMB8oZEptv93ARc2H+P/FJCUyk5UU+ApJmVJnVA== X-Spam-Score: -8.07 X-Migadu-Queue-Id: B87B71A2A4 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=NoO3lghP; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -8.07 X-TUID: zp5oSjjbjuNy Matt writes: > I found cleaning the output was dramatically helped by calling `buffer-substring-no-properties' instead of `buffer-substring' in `org-babel-comint-async-filter'. I'm not sure why `buffer-substring' was originally used. `make test' shows no failures, so I assume it doesn't make a difference...? Could you please elaborate? What was the problem with `buffer-substring'? I am asking because one of the previous versions of `org-babel-comint-wait-for-output' relied upon 'face text property. See a35d16368. > ---- On Tue, 07 Feb 2023 06:40:51 -0500 Ihor Radchenko wrote --- > > That's likely because of the same reasons why prompt did not get cleaned > > in synchronous blocks earlier. See `org-babel-comint-with-output'. > > That, my friend, was a wild ride. > > I'm curious about people's feelings on `org-babel-comint-with-output'. My feelings are: WTF and how does it even work :) More in https://yhetil.org/emacs-devel/87y1tgqhmc.fsf@localhost/ It is a mess, because comint.el is not designed for programmatic use. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at