From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id yAViJcRJY2TTxAAASxT56A (envelope-from ) for ; Tue, 16 May 2023 11:15:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id oA8cJcRJY2QbLQAAauVa8A (envelope-from ) for ; Tue, 16 May 2023 11:15:48 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3F321F730 for ; Tue, 16 May 2023 11:15:48 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pyqlX-0005wl-85; Tue, 16 May 2023 05:14:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyqlW-0005wc-6L for emacs-orgmode@gnu.org; Tue, 16 May 2023 05:14:42 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyqlT-0000b6-T1 for emacs-orgmode@gnu.org; Tue, 16 May 2023 05:14:41 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 82B3D240107 for ; Tue, 16 May 2023 11:14:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1684228475; bh=dnoloy85O4/qO6Dwas34NtbH6z/3sO+asf+kiWPatn8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=l0NIW6G8Dktel/QwA1KCoDaZChIbjYwrT5Rlt3EBdC+YT5pSAYC/V+XzjT47IjJh3 /+SzXnY7hvLIC7XJ/ALtC54GH+iL/ENaOfICkWA/D07IIuPtSa3XdIKwGcC9ClNUuT DHIjq2IQtUfAY5UchJHfJ/boaCOAvKcpOf+GjjjsB/2qxquQUnCMQ6cR6Fteitd4nF q1MrXgb6RLoqW5Es4PXORSR7pM7/GHCxGSB3+idTdrHYKTbhtCSx8GjN21VZDyizTN oJwYF2+R8cnttW/m9cXRv1oZFDSZId9lcTxQShFk6hWkbcSWK8H6nsmYRnfJLtcxM/ J+5Z7Kw1Be5yQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QL9Y70gMqz6twY; Tue, 16 May 2023 11:14:35 +0200 (CEST) From: Ihor Radchenko To: "Christopher M. Miles" Cc: Org mode Subject: Re: [PATCH v2] Re: [PATCH] add a function to only refresh inline images under current headline instead of global buffer In-Reply-To: <64623c09.170a0220.52bf9.9437@mx.google.com> References: <6461a84b.a70a0220.b6d36.5d00@mx.google.com> <87sfbxhmxe.fsf@localhost> <64623c09.170a0220.52bf9.9437@mx.google.com> Date: Tue, 16 May 2023 09:17:58 +0000 Message-ID: <87y1lo4ou1.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684228548; a=rsa-sha256; cv=none; b=r5Pu0CMDcduQ8yWlBLiEuPr2LtX50ftEucV0ZldvhIdVVPOEavx44k7nZokNw8Ujz6Zigr g6XhSkKP0ZnenU3JiktizYkUvY3LnGak8AQ6HOadpxOO0fJ1oHRPNzFEU+odZnEugLeHnI qJItmfxiz/3Glkbel+kHWk85QBckDlje/JgAJS6z/QJsUnrOUBjxvo/Tnlzjt2mxY1O8sU QIP+1ByTNhDEN8w5ECYx0VHM6pB5iiDhacsvHljkkg1Nikl1gqpBBkp9Cz2GTWAoc7b9s6 JzeqFZDtpAZUoq7SX3HHQk/T0TICAIOSFXGFew8D0d5sQ/oFtSpBgCUFiTRxrw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=l0NIW6G8; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684228548; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Cj8+la2pm4uPXxuQ7Qbd4FTx4DcHhvTjNKYj8LHijK4=; b=dGVTUVojBTC/1Q/9zuycUNDK8lta1GBxvdyiFuAssYnwFNaOobhz/03jHhkZlglnLn0IoU ckNUEKwpsBbfxUeJjMzKtGH8/j+CDQQwZMAO7eLS49ki5b8JM1q5QVqEwmQmIi9KhmfjWX Is7A3YM/N+7cVY6Hchshy42q4ixEA0icWVdEIu/S9cZSru9bYwJAqtiCOom7hzefhWz5Ra xCRmKryTPut7pBokWiFO1/kkaKkGqcd9S8Vn/WdiRvR76qt37rC5HaXPVnwSENUVacbZDb 690GXbHZdXSbKOjJahIPbHiqxH5Jgf6EE9X34HAMRkcyJhACbYBrvWEdKGi39Q== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=l0NIW6G8; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.17 X-Spam-Score: -6.17 X-Migadu-Queue-Id: 3F321F730 X-TUID: ipDcq3O2V+vj "Christopher M. Miles" writes: >> I'd prefer something more closely resembling `org-latex-preview' >> approach with prefix arguments: >> ... >> `org-toggle-inline-images' should also be changed. > > Here is the source code of `org-toggle-inline-images'. I implement this > by reference `org-latex-preview'. I have not write testing, but only > manually tested with Edebug and on actual Org buffer displaying and > disable inline images. The command works fine. Ihor, can you review the code? Unlike `org-latex-preview', here we need to (1) respect active region; (2) keep the backward compatibility for INCLUDE-LINKED. For (1), for example, it would make sense to respect region when prefix argument is C-u and clear images only there. For (2), we need to at least allow toggling images with description using some prefix argument (previously, any prefix argument would do). -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at