From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 9nG1IexWmmTkVQAASxT56A (envelope-from ) for ; Tue, 27 Jun 2023 05:26:36 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id aHqKH+xWmmSvZQAAG6o9tA (envelope-from ) for ; Tue, 27 Jun 2023 05:26:36 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F00C72E91F for ; Tue, 27 Jun 2023 05:26:35 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDzKg-0000rQ-6y; Mon, 26 Jun 2023 23:25:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDzKe-0000r8-Sh for emacs-orgmode@gnu.org; Mon, 26 Jun 2023 23:25:32 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDzKd-0000Te-EH for emacs-orgmode@gnu.org; Mon, 26 Jun 2023 23:25:32 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1qDzKa-00038j-DM for emacs-orgmode@gnu.org; Tue, 27 Jun 2023 05:25:28 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Nick Dokos Subject: Re: [BUG] org-babel-tangle: Header arg `:comments org' produces no comment in the output [9.7-pre (release_9.6.6-418-g294a4d @ /home/nick/src/emacs/org/org-mode/lisp/)] Date: Mon, 26 Jun 2023 23:25:21 -0400 Message-ID: <87y1k5io2m.fsf@alphaville.usersys.redhat.com> References: <87bkh8k3at.fsf@alphaville.usersys.redhat.com> <87r0q3ddnb.fsf@localhost> <87352hk0nt.fsf@alphaville.usersys.redhat.com> <87wmzt6npa.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Cancel-Lock: sha1:W6bsxnh23Snvx2B2zgXw8mt2Doo= Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1687836396; a=rsa-sha256; cv=none; b=LrPw/aLLwKW5Lw38iqO+gLLR95HSGs3utTr0YmvvCcVxC1vg/lh3HR8cGLfyw/4OCS+QNt GCgUl566LfpPTMG3kyBANaO+em+XQvk8PCoXQxVRB1M2/SIjCQJYXx9nA9oplq+iBihfMy SbEK7h3RzOXtjJNK47QUR8ZmKZfp7NT/3Cid3+FMktqFOeIaG0fHjb9F3eKcbKdK14Djbv q/RHwq6ZdPVKYps2UpxJIkK5pw9jKuOXLfNH9qUKpV7nnjYvwLxm/JvdyZMaEwlfLhulGg H/rVv5ZVzG0QjvR13nFx1nIYEm8mdtZnRTsleL92BPCaSOLUC63l/jeBDv7dOQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1687836396; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=X33VtuYc0QAgEQ3S8lQzkIHd94xmufAVi/8QfnetGdw=; b=J5vhioTlyTgVHgKD/N3RPeNaaa+UpK0+PIeDigeXUnBUkczGVcjQwFOH7ZICXtGfsXAfo/ 9BzwZLqHwrG5y3lrvyFSzVmhQk6ohLlb53TpLQyP654G2zWdsKPCHlfiZBNMukeBZtzPh7 8NlbKouiv1xVibK+sV5VNi7HeEemfeV96B9dURZ6sMIS8DvXikXHW6q5JScZyn2Ul1Ipym 7nsivZdjHu4gI5VHuHV4vnQi2vsliDTSEdtemGBm3bnoukkW3/5ymSiyDjTY0Z7drIYIqT yvXbrLYco/K3PMrOEbQxMzHLhMaG5antI283mCSkQ5gB60C6QiiBivPaaxKtgw== Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -2.75 X-Spam-Score: -2.75 X-Migadu-Queue-Id: F00C72E91F X-TUID: zOk25OrkFqxl Ihor Radchenko writes: > Nick Dokos writes: > >> A couple of nits: maybe the comment that `org-back-to-heading' sets match >> data should be deleted? And there is a typo in the initial comment of >> the test you added (thanks for adding it!): `:commends org' should be >> `:comments org'. > > Thanks! > Fixed, on bugfix. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=f56ca5009 > >> Also, I found a couple of places in the code where `org-back-to-heading' is called >> and then match data are used. I don't know if there is a problem or not, but it might >> be worth double checking to make sure that the usage makes sense: >> >> - org.el: l.20792 in `org-forward-heading-same-level' >> - org-mouse.el: l.976 in `org-mouse-transform-to-outline' > > Right. > Fixed, on bugfix. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=57bb9cada > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=0a842cc94 Thank you! -- Nick "There are only two hard problems in computer science: cache invalidation, naming things, and off-by-one errors." -Martin Fowler