From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id GJWKBIlPUmV7JwAAG6o9tA:P1 (envelope-from ) for ; Mon, 13 Nov 2023 17:32:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GJWKBIlPUmV7JwAAG6o9tA (envelope-from ) for ; Mon, 13 Nov 2023 17:32:09 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 820AC5E855 for ; Mon, 13 Nov 2023 17:32:08 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=umanitoba.ca header.s=selector2 header.b=l2UowYhV; dmarc=pass (policy=none) header.from=umanitoba.ca; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=key1; d=yhetil.org; t=1699893129; a=rsa-sha256; cv=pass; b=gZP+Hw1XmJkQaI66RJzTCuRn5WKyhyAEwXS30Cfb1ZNGKOCw1SnQguEAgEiLXxINkQbh8N zH3LHM/bSqlKlE6I0zy+APUQ1ddUNNicK6B88X4J9UJM4w3qVmfNmFXoqceAtwhHvF/UTB JmepWShilPK5nqr/1vIoxhsl3968zFcQBEEJlZsicCRjZzl4SmHQ5YQpVtQdEvR1XX6wC0 Jzolc9wW/ep/Qu0/XHLmeCDRdZQ0iM//QtwpuWTTuIIru23mu+A1F2Hn5yRIDyrGGWXtJI sI3i1FTTjN12GSC4VIvjIOi2R/YikFYJ9YOb+GflFItD5QlwG/ASRoJJ7Fghnw== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=umanitoba.ca header.s=selector2 header.b=l2UowYhV; dmarc=pass (policy=none) header.from=umanitoba.ca; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1699893129; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=R/+IdemL8JlpnaQ4BhWmmGgR0XD6cUErw5CdTQklgTE=; b=CU7zYSG6E+0KRtRAOOfKQjvClSQMxq7NUzUcrIfg8bf7U7iR+HSfViiDy4tw3wP++p1zlT 38c6Qin92y1u0PZ46Mn0db6koMDIVQfmD/66mTUK0aGwMcX0rQ/eI7mTkOy3tMg5Pq0jNz NQjB5j8OfEGH+7MzX+D5fvA+vzPhhJV0Ll+2UtmJ4mX5Gpvq0TKT/K15UPeEywqH6OE5VC jIW5yZtKzulDZVMfecHdTNcV8ZaG+gJp7FarFb/+BZGr8AzY2TVn2JTNlEfuqOCF+k6lpl Y0H78qnmUlGG/lFCudnHPBoNqNSwS79y8ZSkY8pWSkM4rA8xuOkaMUTFYl95nQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r2ZqJ-0001Nz-Nv; Mon, 13 Nov 2023 11:31:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2ZqH-0001M1-Uy for emacs-orgmode@gnu.org; Mon, 13 Nov 2023 11:31:18 -0500 Received: from mail-yt3can01on20700.outbound.protection.outlook.com ([2a01:111:f403:241c::700] helo=CAN01-YT3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2ZqF-0006qJ-I1 for emacs-orgmode@gnu.org; Mon, 13 Nov 2023 11:31:17 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NB4L6MsgKObTku7VEqtjOmuyImVr93Lgn3Fa0OVgjwRE83qpVPJqxPUp1i8ThAHYYWCp4kBAyrb/Pn5PaemHDWkxki/uCysUBvp6wnRHvwHPH4QOxQH92zvApT9E6n1BfFuYpxn5nTi4dy7Il7T814xBTLj/Eb87EEdgNQ2iwpLLqIjwHasQEEgETQzhZG8QNQaprzINqS460dNgraCeGB9o7jQ1lRJGkC4/2a9lrq0lK+22WhjCvslzudMPE2NgSCLNI1bNyzPFRgGcT0oFtKiMRLmFaDZhyVo7b4/rzrfIY52C9C4NELTSguzSNRTUqxD8BM0mmgvZU82TSSR52w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R/+IdemL8JlpnaQ4BhWmmGgR0XD6cUErw5CdTQklgTE=; b=GpJqJh9ueClT0/A02Gd9AtaxLoMQS67s2qqH79hPwZeBq4o10hVX3ZQpCt3+1zIHkl1+8h0Y6lCzplFkPTZPKdTGn07ABjPsnSE9I08/INwBrGFy9aLqukZzibjwKw8DOGx0UaIB1VTV4ZIp+AVV/cbyfCcli3lTN4i0vaiUPAqKvJjChF+ci3+V4BxU6iNvzkCTXFzEEXJqX5GbAqhtAUdzUqkuN5muNSvIpzRbPM8vq45Sk4ANmqJJ3TYuwJrxYTvAzTgAycghN3uhNQLVZHchJiN9nThWyCcbPn/WeKTDOgoUM7A7gcZ1kjR0WH5NVploeQdDd8FPylBHFXFn2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=umanitoba.ca; dmarc=pass action=none header.from=umanitoba.ca; dkim=pass header.d=umanitoba.ca; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umanitoba.ca; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R/+IdemL8JlpnaQ4BhWmmGgR0XD6cUErw5CdTQklgTE=; b=l2UowYhVpUuZSzmtBc1/7SOad4lzg7/Bv86vjyM5ZZ0hnVBmpP4KenLa6CLPQoDi9dyT3ptU3QvRrQdRZzeMFas3CI1Bgpk3bHMZj7LL404tv9fPC7nu2MHhrmq8WZeN1fWeRKA1mDg/SQlzgNLYIl7UdxBoGj/QGq4iI/HGj8Fl2oB1D+y6pYYKjyDjr8nqRTIfn5n9dqlsPVCMjYsIOSjuXBVFwW7gHJCsWr5OJbxyzHeeHWuOXBDTuOoEFcQLIkjMfPsDywRUrjRsMVmRpONxDobJegS3e7jk6wsp35oi9kp0TR23gGOiSmzm1YSe5WDmKmL7RQ9TB1CVWz9UPw== Received: from YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:90::5) by YQBPR0101MB8190.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:51::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.31; Mon, 13 Nov 2023 16:26:10 +0000 Received: from YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM ([fe80::94c8:d86a:210c:c4d6]) by YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM ([fe80::94c8:d86a:210c:c4d6%4]) with mapi id 15.20.6977.029; Mon, 13 Nov 2023 16:26:10 +0000 From: Leo Butler To: Ihor Radchenko CC: "Dr. Arne Babenhauserheide" , Florin Boariu , "emacs-orgmode@gnu.org" Subject: Re: [TASK] Allow customizeable ditaa executable in ob-ditaa.el Thread-Topic: [TASK] Allow customizeable ditaa executable in ob-ditaa.el Thread-Index: AQHaErs4BJAyHfs4zESjqByXk5twpg== Date: Mon, 13 Nov 2023 16:26:10 +0000 Message-ID: <87y1f1k4bi.fsf@t14.reltub.ca> References: <87wmvhnr8b.fsf@t14.reltub.ca> <871qdo5sdh.fsf@web.de> <87y1fwtkth.fsf@localhost> <87sf5f7h04.fsf@t14.reltub.ca> <875y2929pd.fsf@localhost> <878r75odrc.fsf@t14.reltub.ca> <87zfzkvb86.fsf@localhost> In-Reply-To: <87zfzkvb86.fsf@localhost> (Ihor Radchenko's message of "Sat, 11 Nov 2023 10:24:41 +0000") Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Gnus/5.13 (Gnus v5.13) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: YT3PR01MB9964:EE_|YQBPR0101MB8190:EE_ x-ms-office365-filtering-correlation-id: 8e172ef2-3765-4df0-e0a0-08dbe4653f3f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yFPT8tRLLU6MovVw7KFqMo2CiQyZDOoSRHXN7YNr2DdiWCkQQYdbb2REbPqVsTD0HMsui6HG8gcB2cE7yZhGnLqZuPvR1OA7unnbTqbHb4SSFS2TRUC+HDqeZkyA51fNEIdbfn8qQ9zWBKK9KfwrY6cO14HgreiFacWZ+XwogWOfDlDIPzZ1XfUJiRZTD4ix24wGIqTRD1YYpKwkWStQPGbNQSc7FDVpkwyVoT0Q6FMpPSkx/SRrMOXMdRNVNGPWDlYrnRTW3Mg053qR79vlqQ1IJ3FBrZnMyXWXkeQwcSYIC+pB+e+1xcoQ9FnlmyrLM5k9QDzijziVdHhFFZ8qrrlsQWH0AmTAGQPhO+hRhanwUUfidN0QmVuOirhV5ItuuBXdK17g07WO1SWeAUSNWUYi4gqo+PloMoYMjSGXf6d4yAJrsE4RH42RzOt3WJpYrFBQ/Chz/V3UewmMvJ437bSl6CvguURYElz/KJKPKhR3Rt+4ViKPBhtPXZSHYqeTYfmvI6Eu8GGKaetV7lwO9gFPOotqIrS38bTcM4CixHySZcPL0YK2NSSVokJHAqUF1vf1W74zCVLUfM2n+4gfQNjosz3jEhR/EWsPQdwisHZkr9RcSrLb0ufoAEZhKRUv x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(376002)(136003)(396003)(366004)(39860400002)(346002)(230922051799003)(186009)(64100799003)(1800799009)(451199024)(64756008)(54906003)(66446008)(66476007)(76116006)(66946007)(66556008)(786003)(91956017)(6916009)(316002)(38100700002)(38070700009)(122000001)(86362001)(6512007)(9686003)(83380400001)(26005)(71200400001)(6506007)(2906002)(478600001)(6486002)(5660300002)(4326008)(41300700001)(8676002)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?03PYI9s5KBdjHZmF56NMMSL83xjHVZIvRbU8nT1WHEMttT8T+oNyn7axtF?= =?iso-8859-1?Q?XBlxnO+VcaR1wF7mbiKet34VsYnwBQaiGuHWvNc9fCPB016QkerTirUqGJ?= =?iso-8859-1?Q?CSJ0pL8Bfob9nCi1KZs0XWkuyfvseCik0t51emGVHS/ja+N5d/QWM3WOrM?= =?iso-8859-1?Q?bNg0EQAbEhvi5CTznk2JCXfODEU0gr+vrTKUsNsyerPMXBGe4R6/MMiBqH?= =?iso-8859-1?Q?o484q/xDKktehs0YhMKb+CJRyRNUMbZJTRrzeq0jomSVb1qvkMl1ZAmhWC?= =?iso-8859-1?Q?DHvyszYCEpUtoF+GZAX8FUSo0Au1l23TmdP7r2l8CwyPl3GMy+QZ6i64k+?= =?iso-8859-1?Q?CcXR/T18R1cq4bd3fJO+cQ1CojfS6eYuPI/Olc3nAX4ak9GYRT+VQO9won?= =?iso-8859-1?Q?NinBmhfvlKHyJqWiWtc1PIt9bIwWKczHzAZQ7T3lxp549NQqqw/K8J6eXO?= =?iso-8859-1?Q?y0eRehEYtBkIVYlcXhWXkbCu0V+vuxMkFxKBMBS4Xzt3qht0gLAzZ1IVfo?= =?iso-8859-1?Q?WeTbvfmoLpTovECq62uSVJ+ZUR6fNcZ3xN8evGu7ebax9avHlZZ0Lrm8Fb?= =?iso-8859-1?Q?qJX9f0/U/3Bi/2UICPL+OTeo9eoS003Yyx1JOd5iTmiFNoXvBxVcV31nbp?= =?iso-8859-1?Q?bpvJV0OPqbmYjqqt+Ibqd0rKtQKa0htNUAZX3TwKGF+CRnisbZwNoiTD7q?= =?iso-8859-1?Q?inWYrN3O70P+jRPWqafx+SWe6z+PUvZSr5InHq8cQD4p07yuPvRN7QDx4l?= =?iso-8859-1?Q?B8Wmj3Twkrw9i+8Hc+VA/qg3EBBtdm4slKSrWHAAmz+DoYBJHjlEETwD6/?= =?iso-8859-1?Q?Q0Fil2/iI2tR/y6nO2Skxj8vUebYgEkv2mk13AGsaHqH9BOxEFwt7t/JEA?= =?iso-8859-1?Q?JQKYs0/p/tfiqdXVeZOKm4rFFsZGsCgzvfnbywcjyvmZbbdzCGUeQu64LQ?= =?iso-8859-1?Q?0fKsOzyB3vPTjIAl8ll/n2qwsDXkM4nYGwoT97eeFsQsjA3XRJpmfg9NVg?= =?iso-8859-1?Q?DzI2ea2Vm0Exm2+y+qlprNqnz0sTzSSGV23Rl1cg0ii0pZ1Xv51ikOUK6i?= =?iso-8859-1?Q?yEfNkqCXmZaTbkFWGbt7jXDj1tgFaaPJyi2zv1g2m7hJgsg+kIFNMZ/4dK?= =?iso-8859-1?Q?JpGdIFfULsXFhE2TiC4x3xc06BWSdCWKZmMsnBdy6y0oTjCJtqzvwW63cI?= =?iso-8859-1?Q?PahFTUrbZHDTOdc5Uf6+EFy6kzvZdWhRlRJq8EJfCSkqg8nZcrw7UiqQWI?= =?iso-8859-1?Q?pzLVl6rmDmxewGvzLpjLan4C2QOXsN1/BWhJ3dWcyrrwRx/FjlFEVsBhTK?= =?iso-8859-1?Q?0xQz3aN7e+CWdUJA7E8mxVBsVTFhRrejNtKy4Bn5IDLIqu/GOp0C37vFWg?= =?iso-8859-1?Q?RJeUs+bX2qt6T+xgUe0NEWYZevWPjsCHlrgtXdAQpR5HeZea6ZYflSPD4a?= =?iso-8859-1?Q?hYAAapFyQgjheYqhj9QWWxWafWbLuNbOblpXRpXq9eUGwjzWerXpIgTD4S?= =?iso-8859-1?Q?kb6mDs6Ql8lt9VZN4V0PMOx3KQEyXQwFHVDiDGxE0XMrTNUnEGS3g1GGYW?= =?iso-8859-1?Q?g38AqN37IVPlMMyA+dxmjm+PUaSOV50GY7v2L1Txay4JnkAmz+6lzSJSLA?= =?iso-8859-1?Q?lVgWVMxYa/If85cohT223rUmDSvKJv/Fk6PikHl8mmzrqs6SQ5nBv5+A?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: umanitoba.ca X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 8e172ef2-3765-4df0-e0a0-08dbe4653f3f X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2023 16:26:10.7039 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4f80dd0b-338c-4e4c-8a14-90446962f7b8 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lFsFaabkJcrloNOQpLvbtTSo4POnHiWvzGTQd48JmojW7+tkFjnREeB+CgyvtTCoX3kRd2OIRgh0ru+bn4VblQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB8190 Received-SPF: pass client-ip=2a01:111:f403:241c::700; envelope-from=Leo.Butler@umanitoba.ca; helo=CAN01-YT3-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 820AC5E855 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -9.65 X-Spam-Score: -9.65 X-TUID: IAA3SNhKWUcS On Sat, Nov 11 2023, Ihor Radchenko wrote: > Leo Butler writes: > >>> And even if we do want to add certain features in future (like >>> supporting ditaa executable herein), it does not mean that we have to >>> rush them by any cost. >> >> Ihor, I don't understand that sentence. >> >> The *documentation* patch was intended to show that ob-ditaa did not >> need to be changed. A user can already run ditaa from a script file by >> setting the customization variables appropriately (or, inappropriately, >> as Max said ;-) ). > > Let me elaborate. > The below explanation in your patch relies upon the implementation > detail in `org-babel-execute:ditaa' - how the ditaa command is called. > however, it can easily happen that we change that detail in future. Thanks for your clarifications here and in a related email.=20 > In fact, your explanation is already not correct for > :file foo.eps - org-ditaa-jar-path value is ignored in such scenario: You say `not correct', I say `mutatus mutandis'. > > (cmd (concat org-babel-ditaa-java-cmd > " " java " " org-ditaa-jar-option " " > (shell-quote-argument > (expand-file-name > (if eps org-ditaa-eps-jar-path org-ditaa-jar-path))) > " " cmdline > " " (org-babel-process-file-name in-file) > " " (if pdf-cmd > eps-file > (org-babel-process-file-name out-file)))) > > Further, it won't help with the discussed problem - > trying > (setq org-ditaa-jar-path "flatpak-spawn --host toolbox run ditaa") will > simply fail when passed through `shell-quote-argument'. The patch says "Users may need to use a script to run ditaa." It does not mention passing arbitrary command strings. > > And now imagine that we change how CMD is produced in future. (For > example, there is a WIP branch that unifies escaping command arguments > to avoid vulnerabilities). Your documentation patch may cease working > any moment, causing damage to users who tried to follow it. Or we may > have to constrain the ways we change the internal implementation details > in order to not break the existing documentation. Either way is not good > and that's why I am saying no to your proposed documentation change. Ok, I have a clearer idea of how to proceed. Leo=