From: Ihor Radchenko <yantar92@posteo.net>
To: Kyle Meyer <kyle@kyleam.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-test: Fix zone-dependent miscalculation of days of week
Date: Mon, 03 Jun 2024 15:00:24 +0000 [thread overview]
Message-ID: <87y17mm5pz.fsf@localhost> (raw)
In-Reply-To: <87le3o5ogg.fsf@kyleam.com>
Kyle Meyer <kyle@kyleam.com> writes:
> Three clock tests are failing on my end:
>
> FAILED test-org-clock/clock-drawer-dwim
> FAILED test-org-clock/org-clock-timestamps-change
> FAILED test-org-clok/org-clock-update-time-maybe
>
> Those stem from org-test-day-of-weeks-{abbrev,full} not having the
> expected value. Those variables are supposed to list Sunday through
> Saturday in the machine's locale. Here's what I see on my end:
>
> org-test-day-of-weeks-full’s value is
> ["Saturday" "Monday" "Monday" "Tuesday" "Wednesday" "Thursday"
> "Friday"]
>
> The patch below fixes the issue on my end. In addition to my usual
> locale, I tested it with another one (de_BE.utf8), and all the tests
> passed.
> ...
> (defconst org-test-day-of-weeks-seconds
> - [121223891 ; Sun
> - 30000000 ; Mon
> - 2222222 ; Tue
> - 500000 ; Wed
> - 1000 ; Thu
> - 89173 ; Fri
> - 666666666] ; Sat
> + [302400 ; Sun
> + 388800 ; Mon
> + 475200 ; Tue
> + 561600 ; Wed
> + 648000 ; Thu
> + 734400 ; Fri
> + 820800] ; Sat
I suspect that the failures are because of your timezone.
If my guess is right, there will always be some timezone where a given
number seconds from epoch is a different day...
I am not sure how to address this problem.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2024-06-03 14:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-01 21:43 [PATCH] org-test: Fix zone-dependent miscalculation of days of week Kyle Meyer
2024-06-03 15:00 ` Ihor Radchenko [this message]
2024-06-04 1:45 ` Kyle Meyer
2024-06-04 13:04 ` Ihor Radchenko
-- strict thread matches above, loose matches on Subject: below --
2024-06-04 1:08 Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y17mm5pz.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=kyle@kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).