* [PATCH] Remove Emacs<24.4 compatibility code
@ 2024-12-11 0:43 Morgan Smith
2024-12-25 13:14 ` Ihor Radchenko
0 siblings, 1 reply; 2+ messages in thread
From: Morgan Smith @ 2024-12-11 0:43 UTC (permalink / raw)
To: emacs-orgmode; +Cc: Morgan Smith
* lisp/org-goto.el: Don't conditionally define keys based on if
`isearch-other-control-char' is bound.
Org mode only supports Emacs 27 and later.
---
lisp/org-goto.el | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/lisp/org-goto.el b/lisp/org-goto.el
index f75cc9ed8..aa2a9328a 100644
--- a/lisp/org-goto.el
+++ b/lisp/org-goto.el
@@ -134,14 +134,9 @@ When nil, you can use these keybindings to navigate the buffer:
(org-defkey map "\C-c\C-u" 'outline-up-heading)
map)))
-;; `isearch-other-control-char' was removed in Emacs 24.4.
-(if (fboundp 'isearch-other-control-char)
- (progn
- (define-key org-goto-local-auto-isearch-map "\C-i" 'isearch-other-control-char)
- (define-key org-goto-local-auto-isearch-map "\C-m" 'isearch-other-control-char))
- (define-key org-goto-local-auto-isearch-map "\C-i" nil)
- (define-key org-goto-local-auto-isearch-map "\C-m" nil)
- (define-key org-goto-local-auto-isearch-map [return] nil))
+(define-key org-goto-local-auto-isearch-map "\C-i" nil)
+(define-key org-goto-local-auto-isearch-map "\C-m" nil)
+(define-key org-goto-local-auto-isearch-map [return] nil)
(defun org-goto--local-search-headings (string bound noerror)
"Search and make sure that any matches are in headlines."
--
2.46.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove Emacs<24.4 compatibility code
2024-12-11 0:43 [PATCH] Remove Emacs<24.4 compatibility code Morgan Smith
@ 2024-12-25 13:14 ` Ihor Radchenko
0 siblings, 0 replies; 2+ messages in thread
From: Ihor Radchenko @ 2024-12-25 13:14 UTC (permalink / raw)
To: Morgan Smith; +Cc: emacs-orgmode
Morgan Smith <Morgan.J.Smith@outlook.com> writes:
> * lisp/org-goto.el: Don't conditionally define keys based on if
> `isearch-other-control-char' is bound.
>
> Org mode only supports Emacs 27 and later.
Applied, onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6f00a8348b
We usually keep the old compatibility code in place, unless there is a
clear reason to remove it (e.g. it stays on the way of new
features/improvements). On the other hand, we do not hold on to it
either. So, I accepted this patch.
If you are interested to contribute to Org mode, do note that removing
obsolete compatibility code is one of the lowest priority items among
possible improvements to Org. There are plenty of other places where Org
codebase can use some cleanup.
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-25 13:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-11 0:43 [PATCH] Remove Emacs<24.4 compatibility code Morgan Smith
2024-12-25 13:14 ` Ihor Radchenko
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).