Re: Incompatible change in latest push

From: Bernt Hansen <bernt@norang.ca>
To: Carsten Dominik <dominik@science.uva.nl>
Cc: emacs-orgmode@gnu.org
Subject: Re: Incompatible change in latest push
Date: Thu, 16 Oct 2008 08:28:29 -0400	[thread overview]
Message-ID: <87wsg8afma.fsf@gollum.intra.norang.ca> (raw)
In-Reply-To: <EE7C5C09-F1DA-4F82-8734-18607E797701@uva.nl> (Carsten Dominik's message of "Thu\, 16 Oct 2008 13\:21\:03 +0200")

Thanks for restoring the old behaviour.

This was confusing me a bit -- I have lots of tasks where the clock
drawer is way down in the body of the task after lots of repeated 'DONE'
notes (for some of my cyclic tasks).  I was used to the latest DONE note
being at the top and all of a sudden it looked to me like the logging of
the repeated task stopped working - but in fact the entry was placed
after my :CLOCK: drawer somewhere in the middle of the task and was much
harder to find.

There is no rule that I'm aware of that the drawer needs to be at the
top of the task.  My drawers have moved down for some tasks over the
years because other things were inserted at the top of the task by org
during regular note taking.

I do not have org-cycle-include-plain-lists set.

I want the latest state change note at the top of the task. When I set
a task to WAITING and enter some note with the reason for it waiting
it's easy to find the reason when opening the task during my weekly
review.

Thanks for explaining this :)

Regards,
Bernt (no longer confused)

Carsten Dominik <dominik@science.uva.nl> writes:

> Hi James,
>
>
> If I follow your example, this is what I get:
>
> * TODO Test
>   SCHEDULED: <2008-10-17 Fri +1d>
>   - State "DONE"       [2008-10-16 Thu 13:14]
>   :PROPERTIES:
>   :LOGGING:  lognoterepeat
>   :EFFORT:   2:00
>   :OtherProperty: fish
>   :END:
>
>
> which looks OK to me.  The property drawer is not part of the item,
> because it is indented like the bullet itself.
>
> I guess what you are referring to might be this:  Do you have set
> org-cycle-include-plain-lists?  Then indeed, if you fold
> the note item with TAB, the property drawer disappears under
> the item.  This is a "bug" in the implementation of plain list
> folding which really should only extend to the end of the item.
> However, the implementation currently used simply makes the
> plain list item an outline heading just like a line starting
> with stars.
>
> Is this what you are referring to, or do I misunderstand?
>
> - Carsten
>
> On Oct 16, 2008, at 12:02 PM, James TD Smith wrote:
>
>> Hi Carsten,
>>
>> On 2008-10-16 06:55:02(+0200), Carsten Dominik wrote:
>>> Hi,
>>>
>>> after a request, I just added a new variable
>>> `org-log-state-notes-insert-after-drawers' with default nil.
>>> This means that state change notes are now by default
>>> inserted again *before* any drawers.  This was the
>>> original behaviour, which changed temporarily in version 6.08.
>>
>> I'm trying to figure out why anyone would want this behaviour. I
>> first noticed
>> it when the clock and properties drawers in some of my org entries
>> seemed to
>> disappear. After working out what was going on I decided it was a
>> bug and wrote
>> a patch to fix it.
>>
>> It makes no sense to me for the drawers in an entry to be swallowed
>> up by state
>> change notes. The drawers are not part of the entry, not the note,
>> and should
>> remain outside of the note. While having the drawers in the notes
>> does not stop
>> org from finding them, it does mean that you can't tell at a glance
>> if an entry
>> has clocked times or properties set as the relevant drawers will be
>> hidden in
>> one of the notes and not visible when the entry is first opened.
>>
>> For example, say you have a task as below:
>>
>> ,----
>> | * TODO Test
>> |   SCHEDULED: <2008-10-16 Wed +1d>
>> |   :PROPERTIES:
>> |   :LOGGING:  lognoterepeat
>> |   :EFFORT:   2:00
>> |   :OtherProperty: fish
>> |   :END:
>> `----
>>
>> When the entry is initially opened it appear as below:
>>
>> ,----
>> | * TODO Test
>> |   SCHEDULED: <2008-10-16 Wed +1d>
>> |   :PROPERTIES:...
>> `----
>>
>> If filing notes before drawers is enabled, the first time this is
>> marked done
>> the properties drawer will be included in the note, so the next time
>> the user
>> looks at it they will see this:
>>
>> ,----
>> | * TODO Test
>> |   SCHEDULED: <2008-10-17 Wed +1d>
>> |   - State "DONE"       [2008-10-16 Thu 10:45]...
>> `----
>>
>> I imagine new org users will find it confusing when adding a note to
>> an entry
>> makes their drawers appear to vanish. It confused me and I've been
>> using org for
>> quite a while.
>>
>> I have no problem with keeping this a configurable option so anyone
>> who wants
>> the old behaviour can have it, but I think the default should be t.
>>
>> James
>>
>> --
>> |-<James TD Smith>-<email/ahktenzero@mohorovi.cc>-|
>>
>>
>>
>>
>>
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Remember: use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode