From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernt Hansen Subject: Re: [PATCH 0/2] Teach org-version to include git version information Date: Wed, 19 Aug 2009 10:42:00 -0400 Message-ID: <87ws4zyifb.fsf@gollum.intra.norang.ca> References: <1250616163-11733-1-git-send-email-bernt@norang.ca> <87tz04yrk0.fsf@gollum.intra.norang.ca> <87prasypiv.fsf@gollum.intra.norang.ca> <87iqgkyoic.fsf@gollum.intra.norang.ca> <87eir8ylni.fsf@gollum.intra.norang.ca> <10259.1250690543@gamaville.dokosmarshall.org> <10437.1250692180@gamaville.dokosmarshall.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MdmMg-0008TY-BM for emacs-orgmode@gnu.org; Wed, 19 Aug 2009 10:42:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MdmMc-0008S2-Fn for emacs-orgmode@gnu.org; Wed, 19 Aug 2009 10:42:13 -0400 Received: from [199.232.76.173] (port=54057 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MdmMc-0008Rx-Ad for emacs-orgmode@gnu.org; Wed, 19 Aug 2009 10:42:10 -0400 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:49956) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MdmMa-0004E6-TB for emacs-orgmode@gnu.org; Wed, 19 Aug 2009 10:42:09 -0400 In-Reply-To: <10437.1250692180@gamaville.dokosmarshall.org> (Nick Dokos's message of "Wed\, 19 Aug 2009 10\:29\:40 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: nicholas.dokos@hp.com Cc: emacs-orgmode@gnu.org Nick Dokos writes: > Thanks! IIUC, there are then multiple forks in the decision tree: > > o running on Windows or on something else? > > o if on Windows, running native or under cygwin? > > o what shell am I using? cmd.exe and bash under cygwin accept > different syntax - in particular, the GITDIR=foo solution of > setting env variables has no hope of working under cmd.exe - > is that correct? > > Sounds complicated. Maybe the best solution for now is to punt on > the git information on Windows? > > (when (not (member system-type '(ms-dos windows-nt cygwin))) > ...add git info...) > > What about system-type == "darwin"? Does Bernt's code work there? Yes it'll be complicated. Right now I think we should punt and just go back to the old org-version reporting for windows until we can get a better working solution since the current version breaks on windows. I'll try to provide a patch for this. Manish: What value do you have for system-type? I expect it says 'windows-nt' If that's true then the problem is determining if - git is installed - what version? Msysgit? cygwin git? - what shells are available (since CMD.exe has little hope of working) - msysgit bash - cygwin shell - cmd (won't work if msysgit was installed with git in the msysgit bash shell only) - running some other shell (git-bash, cygwin) so the git executable is available and provide the right syntax for each to Do The Right Thing(tm) Right now I'm inclined to skip the git-version magic if system-type is windows-nt just to stop it from breaking on that platform. -Bernt