From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sebastian Rose <sebastian_rose@gmx.de>
Subject: Re: [Patch] file protocol in HTML links
Date: Thu, 27 May 2010 23:34:47 +0200
Message-ID: <87wrupyqo8.fsf@gmx.de>
References: <874ohvm2bk.fsf@gmx.de> <87zkznkn2p.fsf@gmx.de>
	<99BD81F0-3064-43B7-9BF9-65EC68802056@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from [140.186.70.92] (port=53576 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OHkjJ-0006zS-Om
	for emacs-orgmode@gnu.org; Thu, 27 May 2010 17:35:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <sebastian_rose@gmx.de>) id 1OHkjB-0003Tq-Ng
	for emacs-orgmode@gnu.org; Thu, 27 May 2010 17:35:00 -0400
Received: from mail.gmx.net ([213.165.64.20]:35159)
	by eggs.gnu.org with smtp (Exim 4.69)
	(envelope-from <sebastian_rose@gmx.de>) id 1OHkjB-0003Ta-Av
	for emacs-orgmode@gnu.org; Thu, 27 May 2010 17:34:57 -0400
In-Reply-To: <99BD81F0-3064-43B7-9BF9-65EC68802056@gmail.com> (Carsten
	Dominik's message of "Thu, 27 May 2010 10:57:41 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: Emacs-orgmode mailing list <emacs-orgmode@gnu.org>

Carsten Dominik <carsten.dominik@gmail.com> writes:
> Hi Sebastian,
>
> can you then please make a patch that reverts the incorrect fix and installs
> your better version?  Against the current master?


Hi Carsten,


I saw you applied the patch.  There is nothing I'd want to remove in the
code, as it is indeed OK to prepend the protocol part to all the other
URIs.
Is there still something I should do?


   Sebastian


> Thanks!
>
> - Carsten
>
> On May 26, 2010, at 11:51 AM, Sebastian Rose wrote:
>
>> Sebastian Rose <sebastian_rose@gmx.de> writes:
>>> The appended patch removes the protocol part from link URIs, if the
>>> protocol is file. Neccessary, to show images again and make links work.
>>>
>>>
>>> diff --git a/lisp/org-html.el b/lisp/org-html.el
>>> index d5f4775..8f7d0f3 100644
>>> --- a/lisp/org-html.el
>>> +++ b/lisp/org-html.el
>>> @@ -640,7 +640,7 @@ MAY-INLINE-P allows inlining it as an image."
>>> 	 (setq thefile
>>> 	    (let
>>> 	       ((str (org-export-html-format-href thefile)))
>>> -	       (if type
>>> +	       (if (and type (not (string= "file" type)))
>>> 		  (concat type ":" str)
>>> 		  str)))
>>
>> Hi,
>>
>>
>> I just pulled and saw it was fixed already - but in a wrong way, I
>> believe. How  about an absolute link URL with a different protocol like
>> gopher?
>>
>> I think adding the protocol should be done, if the protocol is different
>> from that used to deliver the file which contains the link.
>>
>> There's no need to add the protocol to an absolute path.
>>
>>
>>
>>  Sebastian
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Please use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
> - Carsten