emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug in org-colview/org-beamer?
@ 2010-07-31  7:24 Simon Guest
  2010-07-31 10:37 ` [PATCH] " Noorul Islam
  0 siblings, 1 reply; 4+ messages in thread
From: Simon Guest @ 2010-07-31  7:24 UTC (permalink / raw)
  To: emacs-org list

Hi,

I'm making my first real Org mode Beamer presentation, using org-mode
7.01g, and trying to set the ignore_heading for a multi-column slide.

In column mode, when I hit 'e' in the Env column, Emacs says:
Wrong type argument: commandp, org-beamer-set-environment-tag
(and org-beamer-set-environment-tag does not appear to be defined
anywhere).

It's triggered from this code in org-colview.el
     ((equal key "BEAMER_env")
      (setq eval '(org-with-point-at pom
		    (call-interactively 'org-beamer-set-environment-tag))))

Any idea what's wrong?

Please tell me if I should use the bug tracker for this, rather than ask on
the list.

cheers,
Simon

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] Bug in org-colview/org-beamer?
  2010-07-31  7:24 Bug in org-colview/org-beamer? Simon Guest
@ 2010-07-31 10:37 ` Noorul Islam
  2010-07-31 10:48   ` Patchwork: Patch 184 Accepted Bastien Guerry
  2010-07-31 10:48   ` [PATCH] Bug in org-colview/org-beamer? Bastien
  0 siblings, 2 replies; 4+ messages in thread
From: Noorul Islam @ 2010-07-31 10:37 UTC (permalink / raw)
  To: Simon Guest; +Cc: emacs-org list


[-- Attachment #1.1: Type: text/plain, Size: 949 bytes --]

On Sat, Jul 31, 2010 at 12:54 PM, Simon Guest <simon.guest@tesujimath.org>wrote:

> Hi,
>
> I'm making my first real Org mode Beamer presentation, using org-mode
> 7.01g, and trying to set the ignore_heading for a multi-column slide.
>
> In column mode, when I hit 'e' in the Env column, Emacs says:
> Wrong type argument: commandp, org-beamer-set-environment-tag
> (and org-beamer-set-environment-tag does not appear to be defined
> anywhere).
>
> It's triggered from this code in org-colview.el
>     ((equal key "BEAMER_env")
>      (setq eval '(org-with-point-at pom
>                    (call-interactively 'org-beamer-set-environment-tag))))
>
> Any idea what's wrong?
>
>
This function was renamed to org-beamer-select-environment and I think it
was not changed here.

The attached patch should solve the problem.

* lisp/org-colview.el
  Use org-beamer-select-environment instead
of org-beamer-set-environment-tag

Thanks and Regards
Noorul

[-- Attachment #1.2: Type: text/html, Size: 1407 bytes --]

[-- Attachment #2: orgmode.columnview.diff.txt --]
[-- Type: text/plain, Size: 568 bytes --]

diff --git a/lisp/org-colview.el b/lisp/org-colview.el
index 8c0ade2..dc0ab04 100644
--- a/lisp/org-colview.el
+++ b/lisp/org-colview.el
@@ -468,7 +468,7 @@ Where possible, use the standard interface for changing this line."
 		    (call-interactively 'org-schedule))))
      ((equal key "BEAMER_env")
       (setq eval '(org-with-point-at pom
-		    (call-interactively 'org-beamer-set-environment-tag))))
+		    (call-interactively 'org-beamer-select-environment))))
      (t
       (setq allowed (org-property-get-allowed-values pom key 'table))
       (if allowed

[-- Attachment #3: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Patchwork: Patch 184 Accepted
  2010-07-31 10:37 ` [PATCH] " Noorul Islam
@ 2010-07-31 10:48   ` Bastien Guerry
  2010-07-31 10:48   ` [PATCH] Bug in org-colview/org-beamer? Bastien
  1 sibling, 0 replies; 4+ messages in thread
From: Bastien Guerry @ 2010-07-31 10:48 UTC (permalink / raw)
  To: emacs-orgmode

Patch 184 (http://patchwork.newartisans.com/patch/184/) is now Accepted.

This relates to the following submission:

http://mid.gmane.org/%3CAANLkTimHMebUD-keygj1XD5cxO0uRffbrspBSjFgwOO5%40mail.gmail.com%3E

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Bug in org-colview/org-beamer?
  2010-07-31 10:37 ` [PATCH] " Noorul Islam
  2010-07-31 10:48   ` Patchwork: Patch 184 Accepted Bastien Guerry
@ 2010-07-31 10:48   ` Bastien
  1 sibling, 0 replies; 4+ messages in thread
From: Bastien @ 2010-07-31 10:48 UTC (permalink / raw)
  To: Noorul Islam; +Cc: emacs-org list

Noorul Islam <noorul@noorul.com> writes:

> The attached patch should solve the problem.

Applied, thanks.

-- 
 Bastien

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-07-31 10:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-31  7:24 Bug in org-colview/org-beamer? Simon Guest
2010-07-31 10:37 ` [PATCH] " Noorul Islam
2010-07-31 10:48   ` Patchwork: Patch 184 Accepted Bastien Guerry
2010-07-31 10:48   ` [PATCH] Bug in org-colview/org-beamer? Bastien

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).