From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eric Schulte" Subject: Re: [babel] help debugging org-babel-execute-buffer Date: Fri, 27 Aug 2010 08:21:18 -0600 Message-ID: <87wrrcxhk1.fsf@gmail.com> References: <17530.1282195997@gamaville.dokosmarshall.org> <87d3t6d9wc.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from [140.186.70.92] (port=60322 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oozo7-0003VN-77 for emacs-orgmode@gnu.org; Fri, 27 Aug 2010 10:21:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oozo5-0006G1-BC for emacs-orgmode@gnu.org; Fri, 27 Aug 2010 10:21:27 -0400 Received: from mail-px0-f169.google.com ([209.85.212.169]:35173) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oozo5-0006Fk-5i for emacs-orgmode@gnu.org; Fri, 27 Aug 2010 10:21:25 -0400 Received: by pxi5 with SMTP id 5so1935659pxi.0 for ; Fri, 27 Aug 2010 07:21:23 -0700 (PDT) In-Reply-To: <87d3t6d9wc.fsf@gmail.com> (Eric Schulte's message of "Wed, 25 Aug 2010 08:50:11 -0600") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: nicholas.dokos@hp.com Cc: emacs-orgmode@gnu.org This fix has now been applied. Best -- Eric "Eric Schulte" writes: > Hi Nick, > > Thanks for hunting this bug down. > > Nick Dokos writes: > >> Austin Frank wrote: >> >> >>> I have a document that always throws an error when I call >>> org-babel-execute-buffer. I'd guess that there's one particular block >>> that is to blame, but I can't tell which block babel is in at the point >>> when the error is thrown. >>> >>> The error is: >>> >>> #v+ >>> Debugger entered--Lisp error: (invalid-function org-save-outline-visibility) >>> org-save-outline-visibility(t 1 nil nil) >>> org-babel-execute-buffer(nil) >>> call-interactively(org-babel-execute-buffer nil nil) >>> #v- >>> >>> Looking at the macro for org-save-outline-visibility, I think the >>> problem has to do with the last two arguments being passed in as nil >>> nil. I don't, however, know how this is happening. >>> >> >> I think this is a bug: org-save-outline-visibility is indeed a macro, >> defined in org.el, but ob.el does not require org.el, so when it is >> compiled, the compiler thinks it's a function that will be defined elsewhere. >> If the uncompiled ob.el is loaded, there should be no problem. >> >> Two possible solutions: >> >> - (require 'org) in ob.el. > > This first solution can't work, because org.el requires ob.el, and > circular requires are not allowed. > >> >> - move the definition of the macro to org-macs.el (which is required >> by ob.el *and* org.el.) >> >> I'd vote for the second, but Carsten and/or Eric might have a different >> preference. >> > > I agree this sounds like a good solution, if Carsten agrees then I will > apply it. > > Thanks -- Eric > >> >> Nick >> >> _______________________________________________ >> Emacs-orgmode mailing list >> Please use `Reply All' to send replies to the list. >> Emacs-orgmode@gnu.org >> http://lists.gnu.org/mailman/listinfo/emacs-orgmode