emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: 11042@debbugs.gnu.org
Subject: bug#11042: 24.0.94; dangerous org manual: parse-time-months and parse-time-weekdays
Date: Wed, 21 Mar 2012 21:24:55 +0100	[thread overview]
Message-ID: <87wr6d66so.fsf__41823.8352904611$1332361480$gmane$org@web.de> (raw)
In-Reply-To: <87haxiuk8t.fsf__7447.95193099907$1332338401$gmane$org@altern.org> (Bastien's message of "Wed, 21 Mar 2012 15:00:34 +0100")

Bastien <bzg@altern.org> writes:

> Hi Michael,
> Michael Heerdegen <michael_heerdegen@web.de> writes:
> > The org-mode manual under the node "The date/time prompt" tells:
> >
> >   "[...] The function understands English month and weekday
> > abbreviations.  If
> > you want to use unabbreviated names and/or other languages, configure
> > the variables `parse-time-months' and `parse-time-weekdays'."
> >
> > It doesn't tell how the user can do that.  Even worse,
> > `parse-time-months' and `parse-time-weekdays' are not defined as user
> > options and undocumented!
> >
> > After reading the above section in the org manual, users may replace
> > the English names with e.g. German ones in their config.  Seems this
> > is not a good idea, as this user question in gnu.emacs.gnus shows:
> >
> > http://groups.google.com/group/gnu.emacs.gnus/browse_thread/thread/8dde85b5ff3ab454/a02ddb878bfa1eb9
> The thread doesn't tell what is wrong with setting `parse-time-months'
> and `parse-time-weekdays'.  Can you expand a bit more on this?

The thread is not completely visible in google groups, dunno why.
Please read at gnu.emacs.gnus with a newsreader.

The problem was that the user replaced the English names with German
names - instead of adding them to the lists.  This broke Gnus.

Currently, `parse-time-months' and `parse-time-weekdays' are internal
variables with no docstring.  Seems they are not intended to be changed
by the user.  Other packages may rely on the fact that the default
values aren't changed.

If they are supposed to be configured by the user, they should get a
documented defcustom.

At least, the documentation in the org manual _must_ be improved, so
that the user is enabled to do the right thing without breaking anything

> > BTW1: maybe a better solution would be to define own variables for
> > this purpose in org, instead of letting users change variables in
> > parse-time.el.
> Org heavily depends on parse-time.el.  Providing a defcustom in Org
> that is tied to parse-time.el at the same time is not trivial.

Why not?  You could just write a function `org-parse-time-string' that
binds `parse-time-months' and `parse-time-weekdays' accordingly and
calls `parse-time-string'.  Then you would just need to call this new
function from org code.



  parent reply	other threads:[~2012-03-21 20:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <86wr6htni5.fsf@web.de>
2012-03-21 14:00 ` bug#11042: 24.0.94; dangerous org manual: parse-time-months and parse-time-weekdays Bastien
     [not found] ` <87haxiuk8t.fsf__7447.95193099907$1332338401$gmane$org@altern.org>
2012-03-21 20:24   ` Michael Heerdegen [this message]
     [not found]   ` <87wr6d66so.fsf@web.de>
2012-03-23 21:46     ` bug#11042: " Bastien
2012-03-23 22:27     ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='87wr6d66so.fsf__41823.8352904611$1332361480$gmane$org@web.de' \
    --to=michael_heerdegen@web.de \
    --cc=11042@debbugs.gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).