From mboxrd@z Thu Jan 1 00:00:00 1970 From: Achim Gratz Subject: Re: Problems with (defvar foo) and Emacs 23 Date: Mon, 02 Apr 2012 07:31:34 +0200 Message-ID: <87wr5yg0nd.fsf@Rainer.invalid> References: <87sjgngtzk.fsf@norang.ca> <87aa2vp5ri.fsf@Rainer.invalid> <87aa2vw5mq.fsf@gnu.org> <87y5qfp2wd.fsf@Rainer.invalid> <15968.1333328036@alphaville> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:37877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEZrw-0006Cq-OT for emacs-orgmode@gnu.org; Mon, 02 Apr 2012 01:31:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SEZru-0004qF-Rn for emacs-orgmode@gnu.org; Mon, 02 Apr 2012 01:31:56 -0400 Received: from plane.gmane.org ([80.91.229.3]:42883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEZru-0004q3-L3 for emacs-orgmode@gnu.org; Mon, 02 Apr 2012 01:31:54 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1SEZrt-00046n-6j for emacs-orgmode@gnu.org; Mon, 02 Apr 2012 07:31:53 +0200 Received: from pd9eb5d6b.dip.t-dialin.net ([217.235.93.107]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 02 Apr 2012 07:31:53 +0200 Received: from Stromeko by pd9eb5d6b.dip.t-dialin.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 02 Apr 2012 07:31:53 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Nick Dokos writes: > I assume that we are talking about the seven commits Yes, but likely not all of them (or all changes in them). The only problematic ones are where a dynamically scoped variable is renamed and there are a bunch of others that probably are OK. > $ git log --oneline -100 | grep 'Fix global' > 6cbf1f4 Fix global dynamic variables in org-agenda.el and org.el. > b689cbf Fix global dynamic variables in org-table.el. > 9054ba3 Fix global dynamic variables in org-special-blocks.el. > b46fa17 Fix global dynamic variables in org-clock.el. > 08d9b46 Fix global dynamic variables prefixes in org-bibtex.el. > c24fa19 Fix global dynamic variables prefixes in org-mouse.el. > fcf13e0 Fix global dynamic variables prefixes in org-beamer.el. > > I tried reverting these in a branch: I had to merge lisp/org.el by hand > while reverting the first one, but the rest went through without any > problems. > > Does that seem like the right thing to do for now then? For Emacs 24, it is probably the right thing to do, depending on how much time there is left before release. In hotfix/master the changes should be corrected so that they do what they were supposed to do (i.e. also rename the variables in the caller). Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Wavetables for the Waldorf Blofeld: http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables