From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: [PATCH] Locally scope the variable `org-agenda-tag-filter' in
 `org-agenda-filter-by-tag'
Date: Sun, 14 Apr 2013 10:43:29 +0200
Message-ID: <87wqs58mun.fsf@bzg.ath.cx>
References: <1363776050-82790-1-git-send-email-demon386@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:34003)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1URJY6-0007rA-Jl
	for emacs-orgmode@gnu.org; Sun, 14 Apr 2013 05:48:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1URJY4-0003Tt-3t
	for emacs-orgmode@gnu.org; Sun, 14 Apr 2013 05:48:38 -0400
Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:46022)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1URJY3-0003TR-Un
	for emacs-orgmode@gnu.org; Sun, 14 Apr 2013 05:48:36 -0400
Received: by mail-wg0-f42.google.com with SMTP id k13so721028wgh.1
	for <emacs-orgmode@gnu.org>; Sun, 14 Apr 2013 02:48:35 -0700 (PDT)
In-Reply-To: <1363776050-82790-1-git-send-email-demon386@gmail.com>
	(Muchenxuan Tong's message of "Wed, 20 Mar 2013 18:40:50 +0800")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Muchenxuan Tong <demon386@gmail.com>
Cc: emacs-orgmode@gnu.org

Hi Muchenxuan,

sorry for the delay.  The patch isn't applicable anymore and it has
problems too.

Muchenxuan Tong <demon386@gmail.com> writes:

> * lisp/org-agenda.el: Introduce a local variable tag-filter to replace
>   the global variable `org-agenda-tag-filter'.
>
> This relates to the bug when trying to filter by tag in agenda view with
> entry-text shown. In `org-agenda-filter-apply' ->
> `org-agenda-entry-text-mode', it shows error when the global variable
> `org-agenda-tag-filter' is set. Thus, the variable
> `org-agenda-tag-filter' shouldn't be set in advance.
>
> Modifying the global one will be done anyway in
> `org-agenda-filter-apply', which happens after
> calling (org-agenda-entry-text-mode).

The main problem comes from mixing overlays from hiding entries
(through filtering) and from showing entry text.  I don't think there
is a simple solution to this, but let us know if you find one.

Thanks,

-- 
 Bastien