From: Bastien <bzg@gnu.org>
To: Muchenxuan Tong <demon386@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Locally scope the variable `org-agenda-tag-filter' in `org-agenda-filter-by-tag'
Date: Sun, 14 Apr 2013 10:43:29 +0200 [thread overview]
Message-ID: <87wqs58mun.fsf@bzg.ath.cx> (raw)
In-Reply-To: <1363776050-82790-1-git-send-email-demon386@gmail.com> (Muchenxuan Tong's message of "Wed, 20 Mar 2013 18:40:50 +0800")
Hi Muchenxuan,
sorry for the delay. The patch isn't applicable anymore and it has
problems too.
Muchenxuan Tong <demon386@gmail.com> writes:
> * lisp/org-agenda.el: Introduce a local variable tag-filter to replace
> the global variable `org-agenda-tag-filter'.
>
> This relates to the bug when trying to filter by tag in agenda view with
> entry-text shown. In `org-agenda-filter-apply' ->
> `org-agenda-entry-text-mode', it shows error when the global variable
> `org-agenda-tag-filter' is set. Thus, the variable
> `org-agenda-tag-filter' shouldn't be set in advance.
>
> Modifying the global one will be done anyway in
> `org-agenda-filter-apply', which happens after
> calling (org-agenda-entry-text-mode).
The main problem comes from mixing overlays from hiding entries
(through filtering) and from showing entry text. I don't think there
is a simple solution to this, but let us know if you find one.
Thanks,
--
Bastien
prev parent reply other threads:[~2013-04-14 9:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 10:40 [PATCH] Locally scope the variable `org-agenda-tag-filter' in `org-agenda-filter-by-tag' Muchenxuan Tong
2013-04-14 8:43 ` Bastien [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqs58mun.fsf@bzg.ath.cx \
--to=bzg@gnu.org \
--cc=demon386@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).