From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Performance issues after upgrading from Emacs 23.3 to 24.3 Date: Thu, 09 Jan 2014 22:10:37 +0100 Message-ID: <87wqi897zm.fsf@gmail.com> References: <2014-01-06T17-25-21@devnull.Karl-Voit.at> <871u0kp2s1.fsf@bzg.ath.cx> <2014-01-09T20-05-54@devnull.Karl-Voit.at> <871u0h9c6z.fsf@gmail.com> <2014-01-09T21-15-19@devnull.Karl-Voit.at> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1Mrx-0000Qp-Qk for emacs-orgmode@gnu.org; Thu, 09 Jan 2014 16:10:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1Mrs-0007LL-Fv for emacs-orgmode@gnu.org; Thu, 09 Jan 2014 16:10:25 -0500 Received: from mail-we0-x234.google.com ([2a00:1450:400c:c03::234]:39725) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1Mrs-0007L9-44 for emacs-orgmode@gnu.org; Thu, 09 Jan 2014 16:10:20 -0500 Received: by mail-we0-f180.google.com with SMTP id t61so3303880wes.39 for ; Thu, 09 Jan 2014 13:10:18 -0800 (PST) In-Reply-To: <2014-01-09T21-15-19@devnull.Karl-Voit.at> (Karl Voit's message of "Thu, 9 Jan 2014 21:24:33 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: news1142@Karl-Voit.at Cc: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Karl Voit writes: > M-/ of list item is fast again. > > Re-calculate table is fast again. > > Wohoo! :-) Thanks! Applied. Thank you for the report. > However, M-/ of a big heading is still slow (see profile > below). Probably, I am able to find other examples of slow behavior > on the weekend, where I am using the Linux-machine that has the > issue. This operation is bound to be slow anyway. On top of it, you use `org-indent-mode', which can be costly on large buffer changes. Is it really worse than in 23.3? Also, would you mind testing the following patch on top of master? I don't expect much out of it since you're moving a behemoth, but it may help. Regards, -- Nicolas Goaziou --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Try-something-out.patch >From 6681efd30c34e86ede597b5b9ec219c9358fc7eb Mon Sep 17 00:00:00 2001 From: Nicolas Goaziou Date: Thu, 9 Jan 2014 21:59:59 +0100 Subject: [PATCH] Try something out --- lisp/org-list.el | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lisp/org-list.el b/lisp/org-list.el index c0cf77e..f85c19b 100644 --- a/lisp/org-list.el +++ b/lisp/org-list.el @@ -134,6 +134,8 @@ (declare-function org-export-string-as "ox" (string backend &optional body-only ext-plist)) +(declare-function org-element-type "org-element" (element)) + @@ -489,10 +491,13 @@ group 4: description tag") (t (forward-line -1))))))))))) (defun org-at-item-p () - "Is point in a line starting a hand-formatted item?" + "Non-nil when point is in a line starting a list item." (save-excursion (beginning-of-line) - (and (looking-at (org-item-re)) (org-list-in-valid-context-p)))) + (and (looking-at (org-item-re)) + (or (not (derived-mode-p 'org-mode)) + (memq (org-element-type (save-match-data (org-element-at-point))) + '(item plain-list)))))) (defun org-at-item-bullet-p () "Is point at the bullet of a plain list item?" -- 1.8.5.2 --=-=-=--