emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nick Dokos <ndokos@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: minor problem on major version number
Date: Thu, 26 Jun 2014 14:25:03 -0400	[thread overview]
Message-ID: <87wqc3r0jk.fsf@alphaville.bos.redhat.com> (raw)
In-Reply-To: 87fvira7me.fsf@Rainer.invalid

Achim Gratz <Stromeko@nexgo.de> writes:

> Nick Dokos writes:
>> After last night's git pull, org-version returns "beta_8.3" which
>> broke the major-version calculation above. I hardwired the org version
>> major number above, but I was wondering if we could agree on  some
>> convention/method that will not break in the future - maybe an
>> org-major-version function?
>
> There already is a perfectly good convention available via C-h i
> version-to-list, which means the tag should have been named
> "release_8.3beta" and you do not need to invent your own version parsing
> code.  Meanwhile, put these into local.mk:
>
> GITVERSION ?= $(shell git describe --match release\* --abbrev=6 HEAD)
> ORGVERSION ?= $(subst release_,,$(shell git describe --match release\* --abbrev=0 HEAD))
>
> I'm tempted to install that in targets.mk to avoid further breakage by
> malformed tags.
>

OK - thanks. I modified local.mk as suggested and replaced the
major-version calculation in the init file

  (setq major-version (nth 0 (version-to-list (org-version))))

AFAICT, everything's fine.

Thanks,
Nick

next prev parent reply	other threads:[~2014-06-26 18:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-26 16:14 minor problem on major version number Nick Dokos
2014-06-26 17:44 ` Achim Gratz
2014-06-26 18:25   ` Nick Dokos [this message]
2014-06-26 18:15 ` Alexander Baier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wqc3r0jk.fsf@alphaville.bos.redhat.com \
    --to=ndokos@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).