From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aaron Ecay <aaronecay@gmail.com>
Subject: Re: [RFC] [PATCH] ox-latex: support :float no with	caption	for
 minted listings
Date: Sun, 28 Sep 2014 00:07:06 -0400
Message-ID: <87wq8ol76d.fsf@gmail.com>
References: <1408779394-11436-1-git-send-email-aaronecay@gmail.com>
	<87ha13dm3v.fsf@nicolasgoaziou.fr> <87oavbostg.fsf@gmail.com>
	<87a96uep52.fsf@nicolasgoaziou.fr> <87d2bqpvgr.fsf@gmail.com>
	<87tx514qaa.fsf@nicolasgoaziou.fr> <87r401tdc7.fsf@gmail.com>
	<87oav5eztu.fsf@nicolasgoaziou.fr> <87mw9vqvo1.fsf@gmail.com>
	<877g0zv060.fsf_-_@nicolasgoaziou.fr>
	<87iokfoww4.fsf@gmail.com> <87ppemf78n.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60464)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aaronecay@gmail.com>) id 1XY5ld-0000fs-ER
	for emacs-orgmode@gnu.org; Sun, 28 Sep 2014 00:07:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aaronecay@gmail.com>) id 1XY5lU-0005M1-CO
	for emacs-orgmode@gnu.org; Sun, 28 Sep 2014 00:07:25 -0400
Received: from mail-qc0-x232.google.com ([2607:f8b0:400d:c01::232]:53945)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aaronecay@gmail.com>) id 1XY5lU-0005JM-7v
	for emacs-orgmode@gnu.org; Sun, 28 Sep 2014 00:07:16 -0400
Received: by mail-qc0-f178.google.com with SMTP id x13so8295496qcv.23
	for <emacs-orgmode@gnu.org>; Sat, 27 Sep 2014 21:07:10 -0700 (PDT)
In-Reply-To: <87ppemf78n.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>, emacs-orgmode@gnu.org

Hi Nicolas,

2014ko irailak 23an, Nicolas Goaziou-ek idatzi zuen:
>=20
> Hello,
>=20
> Aaron Ecay <aaronecay@gmail.com> writes:
>=20
>> Thanks for all your feedback.  The patch is now applied on master.
>=20
> Thank you.
>=20
>> I=E2=80=99m confused about how =E2=80=98org-latex--wrap-label=E2=80=99 w=
orks.  It tries to
>> put \label commands outside of floats.  That will yield links that
>> jump to the preceding section, not the specific point in the document
>> where the \label command occurs.  Probably this command should insert
>> \phantomsection before the \label, so that resultant links jump to
>> the right point.  (I=E2=80=99ll make this change if no one objects.)
>=20
> I have no objection.

Done on master.

>=20
>> Merging the functions might only be worth doing if there were any more
>> places where \captionof needed to be used.
>=20
> That's the intent, yes. It would be a waste not to use a package now
> residing in the default list. Among the transcoders where
> `org-latex--wrap-label' is used, some could probably benefit from
> a non-float caption, if requested by the user.

OK.  I=E2=80=99ll think about this.  One question is what type of caption t=
his
should be.  (i.e. \captionof{what?}{the caption}).  Using the catch-all
figure caption type seems most sensible to me, but feedback from other
latex users is welcome.

Thanks,

--=20
Aaron Ecay