emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Achim Gratz <Stromeko@nexgo.de>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ob-shell
Date: Sun, 25 Jan 2015 12:41:56 +0100	[thread overview]
Message-ID: <87wq4b6q9n.fsf@Rainer.invalid> (raw)
In-Reply-To: CA+p9wPA3q1LO5S4++KrKQRLUd2G4Wr=UQN+wHy0TrZNfcEdqgQ@mail.gmail.com

Pascal Fleury writes:
> Here is a patch that will figure out the version of bash in a less
> fork-y way.  It keeps the result in a variable after having gotten it
> the first time by indeed forking to bash.

I still think this should be a defcustom instead with a setter function
that checks for the actual availablity of array variables.  The user
should have the opportunity to not use arrays at all even when the shell
supports it.  Using array variable syntax to get the major version
number of the installled Bash might not work in those shells that don't
have arrays.  I can't test an old Bash, but dash doesn't recognize the
syntax at all.  There should be no fallback to checking just the version
of bash since array variables may have been backported or disabled for
the actual variant of Bash that is used.  Also, the code as presented
doesn't deal with the possibility that Tramp might be invoking a
different shell on a remote machine, but that is a problem in more areas.

+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf rackAttack:

      reply	other threads:[~2015-01-25 11:42 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-22 10:03 2 Org tests failing Sebastien Vauban
2014-05-22 10:48 ` Bastien
     [not found]   ` <87tx8iks22.fsf-E3UqQZAQFPqWIDz0JBNUog@public.gmane.org>
2014-06-18 14:55     ` Sebastien Vauban
2014-06-18 21:49       ` Achim Gratz
2014-06-19  8:36         ` Sebastien Vauban
2014-06-19  9:04           ` Sebastien Vauban
2014-06-19  9:08             ` Sebastien Vauban
2014-06-19 20:05           ` Achim Gratz
2014-06-22  8:35             ` [PATCH] ob-shell (was: 2 Org tests failing) Achim Gratz
2014-06-22 12:50               ` [PATCH] ob-shell Eric Schulte
2014-06-23  6:26                 ` Pascal Fleury
2014-06-23 17:20                   ` Achim Gratz
2014-06-23 20:02                 ` Achim Gratz
2014-07-24  7:38                 ` Alan Schmitt
2014-08-04 11:56                   ` Eric Schulte
2014-08-04 19:48                   ` Achim Gratz
2014-08-13 13:12                     ` Alan Schmitt
2014-08-13 13:20                       ` Pascal Fleury
2014-08-13 13:29                         ` Alan Schmitt
2014-08-22  8:52                           ` Pascal Fleury
2014-08-22 13:08                             ` Pascal Fleury
2014-08-22 18:16                               ` Achim Gratz
2015-01-21 22:58                                 ` Pascal Fleury
2015-01-25 11:41                                   ` Achim Gratz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wq4b6q9n.fsf@Rainer.invalid \
    --to=stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).