From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sacha Chua Subject: [PATCH] ob-sql: Don't print out the command Date: Thu, 24 Dec 2015 12:41:25 -0500 Message-ID: <87wps3eoca.fsf@sachachua.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aC9tc-0004pD-Lj for emacs-orgmode@gnu.org; Thu, 24 Dec 2015 12:41:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aC9tZ-0000Jl-8R for emacs-orgmode@gnu.org; Thu, 24 Dec 2015 12:41:48 -0500 Received: from plane.gmane.org ([80.91.229.3]:52545) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aC9tZ-0000J8-0L for emacs-orgmode@gnu.org; Thu, 24 Dec 2015 12:41:45 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1aC9tX-0003i7-Hs for emacs-orgmode@gnu.org; Thu, 24 Dec 2015 18:41:43 +0100 Received: from 184.175.14.75 ([184.175.14.75]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 24 Dec 2015 18:41:43 +0100 Received: from sacha by 184.175.14.75 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 24 Dec 2015 18:41:43 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Out of curiosity, is there a particular reason why ob-sql messages the whole command, aside from debugging/development purposes? funnykitty on #emacs said that executing a long command set was rather slow because of the message. I've attached a tiny patch to remove the (message ...) in case it's left over from debugging, and I've suggested that funnykitty either use cl-flet to override message or redefine org-babel-execute:sql in the meantime. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-ob-sql-Don-t-print-out-the-command.patch >From 04da1fb280847613290e11ce494ba58f17e951ac Mon Sep 17 00:00:00 2001 From: Sacha Chua Date: Thu, 24 Dec 2015 12:36:40 -0500 Subject: [PATCH] ob-sql: Don't print out the command * lisp/ob-sql.el (org-babel-execute:sql): Don't print out the command in the echo area, since it could be very long. --- lisp/ob-sql.el | 1 - 1 file changed, 1 deletion(-) diff --git a/lisp/ob-sql.el b/lisp/ob-sql.el index 275370e..14d5c61 100644 --- a/lisp/ob-sql.el +++ b/lisp/ob-sql.el @@ -175,7 +175,6 @@ SET COLSEP '|' ") (_ "")) (org-babel-expand-body:sql body params))) - (message command) (org-babel-eval command "") (org-babel-result-cond result-params (with-temp-buffer -- 2.6.3 --=-=-= Content-Type: text/plain Sacha --=-=-=--